From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38217) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3hs9-0002f9-2F for qemu-devel@nongnu.org; Wed, 24 Dec 2014 04:04:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3hs5-0007Nc-SD for qemu-devel@nongnu.org; Wed, 24 Dec 2014 04:04:49 -0500 Received: from mga11.intel.com ([192.55.52.93]:18518) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3hs5-0007NN-Mj for qemu-devel@nongnu.org; Wed, 24 Dec 2014 04:04:45 -0500 From: Liang Li Date: Wed, 24 Dec 2014 16:56:57 +0800 Message-Id: <1419411417-23354-1-git-send-email-liang.z.li@intel.com> Subject: [Qemu-devel] [PATCH] xen-pt: Fix PCI devices re-attach failed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, xen-devel@lists.xensource.com Cc: Liang Li , stefano.stabellini@eu.citrix.com, mtosatti@redhat.com, mst@redhat.com, aliguori@amazon.com, robert.hu@intel.com, yang.z.zhang@intel.com, pbonzini@redhat.com, rth@twiddle.net Use the 'xl pci-attach $DomU $BDF' command to attach more then one PCI devices to the guest, then detach the devices with 'xl pci-detach $DomU $BDF', after that, re-attach these PCI devices again, an error message will be reported like following: libxl: error: libxl_qmp.c:287:qmp_handle_error_response: receive an error message from QMP server: Duplicate ID 'pci-pt-03_10.1' for device. The count of calling xen_pt_region_add and xen_pt_region_del are not the same will cause the XenPCIPassthroughState and it's related QemuOpts object not be released properly. Signed-off-by: Liang Li Reported-by: Longtao Pang --- hw/xen/xen_pt.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c index c1bf357..523b8a2 100644 --- a/hw/xen/xen_pt.c +++ b/hw/xen/xen_pt.c @@ -588,7 +588,6 @@ static void xen_pt_region_add(MemoryListener *l, MemoryRegionSection *sec) XenPCIPassthroughState *s = container_of(l, XenPCIPassthroughState, memory_listener); - memory_region_ref(sec->mr); xen_pt_region_update(s, sec, true); } @@ -598,7 +597,6 @@ static void xen_pt_region_del(MemoryListener *l, MemoryRegionSection *sec) memory_listener); xen_pt_region_update(s, sec, false); - memory_region_unref(sec->mr); } static void xen_pt_io_region_add(MemoryListener *l, MemoryRegionSection *sec) @@ -606,7 +604,6 @@ static void xen_pt_io_region_add(MemoryListener *l, MemoryRegionSection *sec) XenPCIPassthroughState *s = container_of(l, XenPCIPassthroughState, io_listener); - memory_region_ref(sec->mr); xen_pt_region_update(s, sec, true); } @@ -616,7 +613,6 @@ static void xen_pt_io_region_del(MemoryListener *l, MemoryRegionSection *sec) io_listener); xen_pt_region_update(s, sec, false); - memory_region_unref(sec->mr); } static const MemoryListener xen_pt_memory_listener = { -- 1.9.1