From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50910) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3lkZ-0005nR-1N for qemu-devel@nongnu.org; Wed, 24 Dec 2014 08:13:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y3lkP-0003Rb-Dc for qemu-devel@nongnu.org; Wed, 24 Dec 2014 08:13:14 -0500 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:45691) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y3lkP-0003RX-7e for qemu-devel@nongnu.org; Wed, 24 Dec 2014 08:13:05 -0500 Received: by mail-wg0-f53.google.com with SMTP id l18so11157447wgh.26 for ; Wed, 24 Dec 2014 05:13:04 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 24 Dec 2014 14:12:45 +0100 Message-Id: <1419426766-1593-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1419426766-1593-1-git-send-email-pbonzini@redhat.com> References: <1419426766-1593-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 6/4] pc: clean up pre-2.1 compatibility code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: imammedo@redhat.com, dgilbert@redhat.com, mst@redhat.com Now that the alignment is parameterized, we can share the call to acpi_align_size between all three (1.7-2.0/2.1/2.2+) sizing algorithms. Also, with the new rule that SSDT cannot change except with machine-type compat code, the magic 97 constant for a CPU's AML size is not anymore "legacy", so rename it. Signed-off-by: Paolo Bonzini --- hw/i386/acpi-build.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 0729aa8..8c32bb9 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -64,8 +64,8 @@ * a little bit, there should be plenty of free space since the DSDT * shrunk by ~1.5k between QEMU 2.0 and QEMU 2.1. */ -#define ACPI_BUILD_LEGACY_CPU_AML_SIZE 97 -#define ACPI_BUILD_ALIGN_SIZE 0x1000 +#define ACPI_BUILD_CPU_AML_SIZE 97 +#define ACPI_BUILD_ALIGN_SIZE 0x1000 /* #define DEBUG_ACPI_BUILD */ #ifdef DEBUG_ACPI_BUILD @@ -1690,10 +1690,9 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables) */ int legacy_aml_len = guest_info->legacy_acpi_table_size + - ACPI_BUILD_LEGACY_CPU_AML_SIZE * max_cpus; + ACPI_BUILD_CPU_AML_SIZE * max_cpus; int legacy_table_size = - ROUND_UP(tables->table_data->len - aml_len + legacy_aml_len, - ACPI_BUILD_ALIGN_SIZE); + tables->table_data->len - aml_len + legacy_aml_len; if (tables->table_data->len > legacy_table_size) { /* Should happen only with PCI bridges and -M pc-i440fx-2.0. */ error_report("Warning: migration may not work."); @@ -1709,8 +1708,8 @@ void acpi_build(PcGuestInfo *guest_info, AcpiBuildTables *tables) error_report("Warning: migration may not work."); error_report("Warning: please upgrade to a newer machine type."); } - acpi_align_size(tables->table_data, guest_info->acpi_table_align); } + acpi_align_size(tables->table_data, guest_info->acpi_table_align); acpi_align_size(tables->linker, ACPI_BUILD_ALIGN_SIZE); -- 1.8.3.1