From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45216) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5syq-0002XN-48 for qemu-devel@nongnu.org; Tue, 30 Dec 2014 04:20:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y5sym-0003zZ-UJ for qemu-devel@nongnu.org; Tue, 30 Dec 2014 04:20:44 -0500 Received: from mailhub.sw.ru ([195.214.232.25]:38504 helo=relay.sw.ru) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y5syj-0003zC-7z for qemu-devel@nongnu.org; Tue, 30 Dec 2014 04:20:40 -0500 From: "Denis V. Lunev" Date: Tue, 30 Dec 2014 12:20:50 +0300 Message-Id: <1419931250-19259-9-git-send-email-den@openvz.org> In-Reply-To: <1419931250-19259-1-git-send-email-den@openvz.org> References: <1419931250-19259-1-git-send-email-den@openvz.org> Subject: [Qemu-devel] [PATCH 8/8] block/raw-posix: set max_write_zeroes to INT_MAX for regular files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , "Denis V. Lunev" , Peter Lieven , qemu-devel@nongnu.org, Stefan Hajnoczi fallocate() works fine and could handle properly with arbitrary size requests. There is no sense to reduce the amount of space to fallocate. The bigger the size, the better is performance as the amount of journal updates is reduced. Signed-off-by: Denis V. Lunev CC: Kevin Wolf CC: Stefan Hajnoczi CC: Peter Lieven --- block/raw-posix.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/block/raw-posix.c b/block/raw-posix.c index 57b94ad..3e156c4 100644 --- a/block/raw-posix.c +++ b/block/raw-posix.c @@ -292,6 +292,20 @@ static void raw_probe_alignment(BlockDriverState *bs, int fd, Error **errp) } } +static void raw_probe_max_write_zeroes(BlockDriverState *bs) +{ + BDRVRawState *s = bs->opaque; + struct stat st; + + if (fstat(s->fd, &st) < 0) { + return; /* no problem, keep default value */ + } + if (!S_ISREG(st.st_mode) || !s->discard_zeroes) { + return; + } + bs->bl.max_write_zeroes = INT_MAX; +} + static void raw_parse_flags(int bdrv_flags, int *open_flags) { assert(open_flags != NULL); @@ -598,6 +612,7 @@ static int raw_reopen_prepare(BDRVReopenState *state, /* Fail already reopen_prepare() if we can't get a working O_DIRECT * alignment with the new fd. */ if (raw_s->fd != -1) { + raw_probe_max_write_zeroes(state->bs); raw_probe_alignment(state->bs, raw_s->fd, &local_err); if (local_err) { qemu_close(raw_s->fd); @@ -651,6 +666,8 @@ static void raw_refresh_limits(BlockDriverState *bs, Error **errp) raw_probe_alignment(bs, s->fd, errp); bs->bl.opt_mem_alignment = s->buf_align; + + raw_probe_max_write_zeroes(bs); } static ssize_t handle_aiocb_ioctl(RawPosixAIOData *aiocb) -- 1.9.1