From: "Denis V. Lunev" <den@openvz.org>
Cc: Kevin Wolf <kwolf@redhat.com>, "Denis V. Lunev" <den@openvz.org>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 15/19] block/parallels: rename catalog_ names to bat_
Date: Tue, 30 Dec 2014 13:07:08 +0300 [thread overview]
Message-ID: <1419934032-24216-6-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1419934032-24216-1-git-send-email-den@openvz.org>
BAT means 'block allocation table'. Thus this name is clean and shorter
on writing.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
---
block/parallels.c | 48 ++++++++++++++++++++++++------------------------
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/block/parallels.c b/block/parallels.c
index d072276..ddc3aee 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -47,7 +47,7 @@ typedef struct ParallelsHeader {
uint32_t heads;
uint32_t cylinders;
uint32_t tracks;
- uint32_t catalog_entries;
+ uint32_t bat_entries;
uint64_t nb_sectors;
uint32_t inuse;
uint32_t data_off;
@@ -59,8 +59,8 @@ typedef struct BDRVParallelsState {
ParallelsHeader ph;
- uint32_t *catalog_bitmap;
- unsigned int catalog_size;
+ uint32_t *bat;
+ unsigned int bat_size;
unsigned int tracks;
@@ -68,7 +68,7 @@ typedef struct BDRVParallelsState {
} BDRVParallelsState;
-static uint32_t catalog_offset(uint32_t index)
+static uint32_t bat_offset(uint32_t index)
{
return sizeof(ParallelsHeader) + sizeof(uint32_t) * index;
}
@@ -126,26 +126,26 @@ static int parallels_open(BlockDriverState *bs, QDict *options, int flags,
goto fail;
}
- s->catalog_size = le32_to_cpu(s->ph.catalog_entries);
- if (s->catalog_size > INT_MAX / sizeof(uint32_t)) {
+ s->bat_size = le32_to_cpu(s->ph.bat_entries);
+ if (s->bat_size > INT_MAX / sizeof(uint32_t)) {
error_setg(errp, "Catalog too large");
ret = -EFBIG;
goto fail;
}
- s->catalog_bitmap = g_try_new(uint32_t, s->catalog_size);
- if (s->catalog_size && s->catalog_bitmap == NULL) {
+ s->bat = g_try_new(uint32_t, s->bat_size);
+ if (s->bat_size && s->bat == NULL) {
ret = -ENOMEM;
goto fail;
}
ret = bdrv_pread(bs->file, sizeof(ParallelsHeader),
- s->catalog_bitmap, s->catalog_size * sizeof(uint32_t));
+ s->bat, s->bat_size * sizeof(uint32_t));
if (ret < 0) {
goto fail;
}
- for (i = 0; i < s->catalog_size; i++)
- le32_to_cpus(&s->catalog_bitmap[i]);
+ for (i = 0; i < s->bat_size; i++)
+ le32_to_cpus(&s->bat[i]);
qemu_co_mutex_init(&s->lock);
return 0;
@@ -154,7 +154,7 @@ fail_format:
error_setg(errp, "Image not in Parallels format");
ret = -EINVAL;
fail:
- g_free(s->catalog_bitmap);
+ g_free(s->bat);
return ret;
}
@@ -166,9 +166,9 @@ static int64_t seek_to_sector(BDRVParallelsState *s, int64_t sector_num)
offset = sector_num % s->tracks;
/* not allocated */
- if ((index >= s->catalog_size) || (s->catalog_bitmap[index] == 0))
+ if ((index >= s->bat_size) || (s->bat[index] == 0))
return -1;
- return (uint64_t)s->catalog_bitmap[index] * s->off_multiplier + offset;
+ return (uint64_t)s->bat[index] * s->off_multiplier + offset;
}
static int64_t allocate_sector(BlockDriverState *bs, int64_t sector_num)
@@ -181,24 +181,24 @@ static int64_t allocate_sector(BlockDriverState *bs, int64_t sector_num)
idx = sector_num / s->tracks;
offset = sector_num % s->tracks;
- if (idx >= s->catalog_size) {
+ if (idx >= s->bat_size) {
return -EINVAL;
}
- if (s->catalog_bitmap[idx] != 0) {
- return (uint64_t)s->catalog_bitmap[idx] * s->off_multiplier + offset;
+ if (s->bat[idx] != 0) {
+ return (uint64_t)s->bat[idx] * s->off_multiplier + offset;
}
pos = bdrv_getlength(bs->file) >> BDRV_SECTOR_BITS;
bdrv_truncate(bs->file, (pos + s->tracks) << BDRV_SECTOR_BITS);
- s->catalog_bitmap[idx] = pos / s->off_multiplier;
+ s->bat[idx] = pos / s->off_multiplier;
- tmp = cpu_to_le32(s->catalog_bitmap[idx]);
+ tmp = cpu_to_le32(s->bat[idx]);
- ret = bdrv_pwrite_sync(bs->file, catalog_offset(idx), &tmp, sizeof(tmp));
+ ret = bdrv_pwrite_sync(bs->file, bat_offset(idx), &tmp, sizeof(tmp));
if (ret < 0) {
return ret;
}
- return (uint64_t)s->catalog_bitmap[idx] * s->off_multiplier + offset;
+ return (uint64_t)s->bat[idx] * s->off_multiplier + offset;
}
static int cluster_remainder(BDRVParallelsState *s, int64_t sector_num,
@@ -347,7 +347,7 @@ static int parallels_create(const char *filename, QemuOpts *opts, Error **errp)
}
cat_entries = DIV_ROUND_UP(total_size, cl_size);
- cat_sectors = DIV_ROUND_UP(catalog_offset(cat_entries), cl_size);
+ cat_sectors = DIV_ROUND_UP(bat_offset(cat_entries), cl_size);
cat_sectors = (cat_sectors * cl_size) >> BDRV_SECTOR_BITS;
memset(&header, 0, sizeof(header));
@@ -357,7 +357,7 @@ static int parallels_create(const char *filename, QemuOpts *opts, Error **errp)
header.heads = cpu_to_le32(16);
header.cylinders = cpu_to_le32(total_size / BDRV_SECTOR_SIZE / 16 / 32);
header.tracks = cpu_to_le32(cl_size >> BDRV_SECTOR_BITS);
- header.catalog_entries = cpu_to_le32(cat_entries);
+ header.bat_entries = cpu_to_le32(cat_entries);
header.nb_sectors = cpu_to_le64(DIV_ROUND_UP(total_size, BDRV_SECTOR_SIZE));
header.data_off = cpu_to_le32(cat_sectors);
@@ -387,7 +387,7 @@ exit:
static void parallels_close(BlockDriverState *bs)
{
BDRVParallelsState *s = bs->opaque;
- g_free(s->catalog_bitmap);
+ g_free(s->bat);
}
static QemuOptsList parallels_create_opts = {
--
1.9.1
next prev parent reply other threads:[~2014-12-30 10:06 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-30 9:28 [Qemu-devel] [PATCH v2 0/19] write/create for Parallels images with reasonable performance Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 01/19] iotests, parallels: quote TEST_IMG in 076 test to be path-safe Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 02/19] block/parallels: rename parallels_header to ParallelsHeader Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 03/19] block/parallels: switch to bdrv_read Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 04/19] block/parallels: read up to cluster end in one go Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 05/19] block/parallels: add get_block_status Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 06/19] block/parallels: provide _co_readv routine for parallels format driver Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 07/19] block/parallels: replace magic constants 4, 64 with proper sizeofs Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 08/19] block/parallels: _co_writev callback for Parallels format Denis V. Lunev
2014-12-30 9:28 ` [Qemu-devel] [PATCH 09/19] iotests, parallels: test for write into Parallels image Denis V. Lunev
2014-12-30 10:07 ` [Qemu-devel] [PATCH 10/19] block/parallels: support parallels image creation Denis V. Lunev
2014-12-30 10:07 ` [Qemu-devel] [PATCH 11/19] iotests, parallels: test for newly created parallels image via qemu-img Denis V. Lunev
2014-12-30 10:07 ` [Qemu-devel] [PATCH 12/19] parallels: change copyright information in the image header Denis V. Lunev
2014-12-30 10:07 ` [Qemu-devel] [PATCH 13/19] block/parallels: store ParallelsHeader to the BDRVParallelsState Denis V. Lunev
2015-01-13 14:13 ` Roman Kagan
2014-12-30 10:07 ` [Qemu-devel] [PATCH 14/19] block/parallels: create catalog_offset helper Denis V. Lunev
2015-01-13 14:14 ` Roman Kagan
2014-12-30 10:07 ` Denis V. Lunev [this message]
2015-01-13 14:15 ` [Qemu-devel] [PATCH 15/19] block/parallels: rename catalog_ names to bat_ Roman Kagan
2014-12-30 10:07 ` [Qemu-devel] [PATCH 16/19] block/parallels: no need to flush on each block allocation table update Denis V. Lunev
2015-01-13 14:50 ` Roman Kagan
2015-01-13 15:17 ` Denis V. Lunev
2015-01-13 20:16 ` Denis V. Lunev
2015-01-14 12:01 ` Roman Kagan
2015-01-14 12:30 ` Denis V. Lunev
2014-12-30 10:07 ` [Qemu-devel] [PATCH 17/19] block/parallels: delay writing to BAT till bdrv_co_flush_to_os Denis V. Lunev
2015-01-14 13:03 ` Roman Kagan
2015-01-14 13:08 ` Denis V. Lunev
2015-01-14 13:34 ` Roman Kagan
2015-01-14 14:29 ` Denis V. Lunev
2015-01-14 16:44 ` Denis V. Lunev
2014-12-30 10:07 ` [Qemu-devel] [PATCH 18/19] block/parallels: add prealloc-mode and prealloc-size open paramemets Denis V. Lunev
2015-01-14 14:26 ` Roman Kagan
2015-01-14 14:31 ` Denis V. Lunev
2015-01-14 17:22 ` Roman Kagan
2014-12-30 10:07 ` [Qemu-devel] [PATCH 19/19] block/parallels: optimize linear image expansion Denis V. Lunev
2015-01-14 17:56 ` Roman Kagan
2015-01-14 17:57 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419934032-24216-6-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).