From: Tejus GK <tejus.gk@nutanix.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: quintela@redhat.com, peterx@redhat.com, leobras@redhat.com,
berrange@redhat.com, shivam.kumar1@nutanix.com
Subject: Re: [RFC v2 1/1] migration: Update error description whenever migration fails
Date: Tue, 9 May 2023 17:32:17 +0530 [thread overview]
Message-ID: <141c4d9e-a3bc-02e3-fdbe-d2f61605e7a7@nutanix.com> (raw)
In-Reply-To: <11962c60-475a-31a8-ef55-8da6dacca9d2@redhat.com>
On 08/05/23 10:19 pm, Thomas Huth wrote:
> Hi!
>
> On 08/05/2023 17.32, tejus.gk wrote:
>> There are places in the code where the migration is marked failed with
>> MIGRATION_STATUS_FAILED, but the failiure reason is never updated. Hence
>
> s/failiure/failure/
Ack
>
>> libvirt doesn't know why the migration failed when it queries for it.
>>
>> Signed-off-by: tejus.gk <tejus.gk@nutanix.com>
>
> The Signed-off-by line should contain the proper name...
> Is "tejus.gk" really the correct spelling of your name (with only lowercase letters and a dot in it)? If not, please update the line, thanks!
>
> Thomas
>
My bad. My git config seemed to be configure improperly, will fix in the next revision.
Regards,
Tejus
next prev parent reply other threads:[~2023-05-09 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-08 15:32 [RFC v2 0/1] migration: Update error description whenever migration fails tejus.gk
2023-05-08 15:32 ` [RFC v2 1/1] " tejus.gk
2023-05-08 16:49 ` Thomas Huth
2023-05-09 12:02 ` Tejus GK [this message]
2023-05-09 10:16 ` Juan Quintela
2023-05-09 12:32 ` Tejus GK
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141c4d9e-a3bc-02e3-fdbe-d2f61605e7a7@nutanix.com \
--to=tejus.gk@nutanix.com \
--cc=berrange@redhat.com \
--cc=leobras@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=shivam.kumar1@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).