From: "Cédric Le Goater" <clg@redhat.com>
To: Zhenzhong Duan <zhenzhong.duan@intel.com>, qemu-devel@nongnu.org
Cc: alex.williamson@redhat.com, chao.p.peng@intel.com
Subject: Re: [PATCH] vfio/pci: rename vfio_put_device to vfio_pci_put_device
Date: Fri, 22 Sep 2023 16:34:52 +0200 [thread overview]
Message-ID: <141f1a39-6d54-598e-b44a-a313ca7c2c2c@redhat.com> (raw)
In-Reply-To: <20230922025223.1091821-1-zhenzhong.duan@intel.com>
On 9/22/23 04:52, Zhenzhong Duan wrote:
> vfio_put_device() is a VFIO PCI specific function, rename it with
> 'vfio_pci' prefix to avoid confusing.
>
> No functional change.
There is more to be done but it can wait after the big code reshuffle.
> Suggested-by: Cédric Le Goater <clg@redhat.com>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
Applied to vfio-next.
Thanks,
C.
> ---
> hw/vfio/pci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
> index 3b2ca3c24ca2..b2d5010b9f0e 100644
> --- a/hw/vfio/pci.c
> +++ b/hw/vfio/pci.c
> @@ -2826,7 +2826,7 @@ static void vfio_populate_device(VFIOPCIDevice *vdev, Error **errp)
> }
> }
>
> -static void vfio_put_device(VFIOPCIDevice *vdev)
> +static void vfio_pci_put_device(VFIOPCIDevice *vdev)
> {
> g_free(vdev->vbasedev.name);
> g_free(vdev->msix);
> @@ -3317,7 +3317,7 @@ static void vfio_instance_finalize(Object *obj)
> *
> * g_free(vdev->igd_opregion);
> */
> - vfio_put_device(vdev);
> + vfio_pci_put_device(vdev);
> vfio_put_group(group);
> }
>
next prev parent reply other threads:[~2023-09-22 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 2:52 [PATCH] vfio/pci: rename vfio_put_device to vfio_pci_put_device Zhenzhong Duan
2023-09-22 14:34 ` Cédric Le Goater [this message]
2023-10-11 13:02 ` Philippe Mathieu-Daudé
2023-10-11 14:11 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=141f1a39-6d54-598e-b44a-a313ca7c2c2c@redhat.com \
--to=clg@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=chao.p.peng@intel.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenzhong.duan@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).