From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7KKq-0001qL-Gd for qemu-devel@nongnu.org; Sat, 03 Jan 2015 03:45:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7KKk-0002hI-GE for qemu-devel@nongnu.org; Sat, 03 Jan 2015 03:45:24 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Sat, 3 Jan 2015 09:45:01 +0100 Message-Id: <1420274709-30199-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1420274709-30199-1-git-send-email-pbonzini@redhat.com> References: <1420274709-30199-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 1/9] atomic: fix position of volatile qualifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org What needs to be volatile is not the pointer, but the pointed-to value! Cc: qemu-stable@nongnu.org Signed-off-by: Paolo Bonzini --- include/qemu/atomic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/qemu/atomic.h b/include/qemu/atomic.h index 492bce1..93c2ae2 100644 --- a/include/qemu/atomic.h +++ b/include/qemu/atomic.h @@ -122,11 +122,11 @@ #endif #ifndef atomic_read -#define atomic_read(ptr) (*(__typeof__(*ptr) *volatile) (ptr)) +#define atomic_read(ptr) (*(__typeof__(*ptr) volatile*) (ptr)) #endif #ifndef atomic_set -#define atomic_set(ptr, i) ((*(__typeof__(*ptr) *volatile) (ptr)) = (i)) +#define atomic_set(ptr, i) ((*(__typeof__(*ptr) volatile*) (ptr)) = (i)) #endif /* These have the same semantics as Java volatile variables. -- 1.8.3.1