From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Wu <peter@lekensteyn.nl>
Subject: [Qemu-devel] [PULL 8/9] block/iscsi: fix uninitialized variable
Date: Sat, 3 Jan 2015 09:45:08 +0100 [thread overview]
Message-ID: <1420274709-30199-9-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1420274709-30199-1-git-send-email-pbonzini@redhat.com>
From: Peter Wu <peter@lekensteyn.nl>
'ret' was never initialized in the success path.
Signed-off-by: Peter Wu <peter@lekensteyn.nl>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
block/iscsi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index ed375fc..12ddbfb 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1286,7 +1286,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags,
QemuOpts *opts;
Error *local_err = NULL;
const char *filename;
- int i, ret;
+ int i, ret = 0;
if ((BDRV_SECTOR_SIZE % 512) != 0) {
error_setg(errp, "iSCSI: Invalid BDRV_SECTOR_SIZE. "
--
1.8.3.1
next prev parent reply other threads:[~2015-01-03 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 8:45 [Qemu-devel] [PULL 0/9] Misc changes for 2015-01-03 (icount, migration, iscsi, sdhci-pci) Paolo Bonzini
2015-01-03 8:45 ` [Qemu-devel] [PULL 1/9] atomic: fix position of volatile qualifier Paolo Bonzini
2015-01-03 8:45 ` [Qemu-devel] [PULL 2/9] target-ppc: pass DisasContext to SPR generator functions Paolo Bonzini
2015-01-03 8:45 ` [Qemu-devel] [PULL 3/9] cpu-exec: add a new CF_USE_ICOUNT cflag Paolo Bonzini
2015-01-03 8:45 ` [Qemu-devel] [PULL 4/9] translate: check cflags instead of use_icount global Paolo Bonzini
2015-01-03 8:45 ` [Qemu-devel] [PULL 5/9] gen-icount: " Paolo Bonzini
2015-01-03 8:45 ` [Qemu-devel] [PULL 6/9] serial: refine serial_thr_ipending_needed Paolo Bonzini
2015-01-03 8:45 ` [Qemu-devel] [PULL 7/9] pckbd: set bits 2-3-6-7 of the output port by default Paolo Bonzini
2015-01-03 8:45 ` Paolo Bonzini [this message]
2015-01-03 8:45 ` [Qemu-devel] [PULL 9/9] pci: move REDHAT_SDHCI device ID to make room for Rocker Paolo Bonzini
2015-01-09 17:58 ` [Qemu-devel] [PULL 0/9] Misc changes for 2015-01-03 (icount, migration, iscsi, sdhci-pci) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420274709-30199-9-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=peter@lekensteyn.nl \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).