From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44912) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7KL3-00023p-9l for qemu-devel@nongnu.org; Sat, 03 Jan 2015 03:45:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y7KKx-0002ni-Kv for qemu-devel@nongnu.org; Sat, 03 Jan 2015 03:45:37 -0500 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:48502) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y7KKw-0002mC-Rm for qemu-devel@nongnu.org; Sat, 03 Jan 2015 03:45:31 -0500 Received: by mail-wi0-f180.google.com with SMTP id n3so598082wiv.7 for ; Sat, 03 Jan 2015 00:45:30 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Sat, 3 Jan 2015 09:45:08 +0100 Message-Id: <1420274709-30199-9-git-send-email-pbonzini@redhat.com> In-Reply-To: <1420274709-30199-1-git-send-email-pbonzini@redhat.com> References: <1420274709-30199-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 8/9] block/iscsi: fix uninitialized variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Wu From: Peter Wu 'ret' was never initialized in the success path. Signed-off-by: Peter Wu Signed-off-by: Paolo Bonzini --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index ed375fc..12ddbfb 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1286,7 +1286,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *options, int flags, QemuOpts *opts; Error *local_err = NULL; const char *filename; - int i, ret; + int i, ret = 0; if ((BDRV_SECTOR_SIZE % 512) != 0) { error_setg(errp, "iSCSI: Invalid BDRV_SECTOR_SIZE. " -- 1.8.3.1