From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y88ZM-0002iS-PW for qemu-devel@nongnu.org; Mon, 05 Jan 2015 09:23:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y88ZL-0006qi-QK for qemu-devel@nongnu.org; Mon, 05 Jan 2015 09:23:44 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:54680) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y88ZL-0006eQ-Bm for qemu-devel@nongnu.org; Mon, 05 Jan 2015 09:23:43 -0500 From: Peter Maydell Date: Mon, 5 Jan 2015 14:23:32 +0000 Message-Id: <1420467812-31917-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] include/qom/cpu.h: Add missing documentation for some CPUClass methods List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jens Freimann , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Anthony Liguori , patches@linaro.org The CPUClass QOM methods virtio_is_big_endian, write_elf{32,64}_note and write_elf{32,64}_qemunote were added without any description being added to the doc comment. Correct this omission. Signed-off-by: Peter Maydell --- More informative phrasings for the elf note callbacks welcome... include/qom/cpu.h | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/include/qom/cpu.h b/include/qom/cpu.h index 2098f1c..f2d7de1 100644 --- a/include/qom/cpu.h +++ b/include/qom/cpu.h @@ -82,6 +82,10 @@ struct TranslationBlock; * @do_unassigned_access: Callback for unassigned access handling. * @do_unaligned_access: Callback for unaligned access handling, if * the target defines #ALIGNED_ONLY. + * @virtio_is_big_endian: Callback to return true if a CPU which supports + * runtime configurable endianness is currently big-endian. Non-configurable + * CPUs can use the default implementation of this method. This method should + * not be used by any callers other than the pre-1.0 virtio devices. * @memory_rw_debug: Callback for GDB memory access. * @dump_state: Callback for dumping state. * @dump_statistics: Callback for dumping statistics. @@ -96,6 +100,14 @@ struct TranslationBlock; * @gdb_read_register: Callback for letting GDB read a register. * @gdb_write_register: Callback for letting GDB write a register. * @debug_excp_handler: Callback for handling debug exceptions. + * @write_elf64_note: Callback for writing a CPU-specific ELF note to a + * 64-bit VM coredump. + * @write_elf32_qemunote: Callback for writing a CPU- and QEMU-specific ELF + * note to a 32 bit VM coredump. + * @write_elf32_note: Callback for writing a CPU-specific ELF note to a + * 32-bit VM coredump. + * @write_elf32_qemunote: Callback for writing a CPU- and QEMU-specific ELF + * note to a 32 bit VM coredump. * @vmsd: State description for migration. * @gdb_num_core_regs: Number of core registers accessible to GDB. * @gdb_core_xml_file: File name for core registers GDB XML description. -- 1.9.1