* [Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode instructions correctly
@ 2015-01-05 20:42 David Morrison
2015-01-06 3:57 ` Fam Zheng
0 siblings, 1 reply; 2+ messages in thread
From: David Morrison @ 2015-01-05 20:42 UTC (permalink / raw)
To: qemu-devel, qemu-trivial, proljc, peter.maydell; +Cc: David Morrison
Fixed the decoding of "system" instructions (starting with 0x2)
in dec_sys() in translate.c. In particular, the l.trap instruction
is now correctly decoded, which enables for singlestepping and
breakpoints to be set in GDB.
---
target-openrisc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
index 407bd97..d36278f 100644
--- a/target-openrisc/translate.c
+++ b/target-openrisc/translate.c
@@ -1320,7 +1320,7 @@ static void dec_sys(DisasContext *dc, uint32_t insn)
#ifdef OPENRISC_DISAS
uint32_t K16;
#endif
- op0 = extract32(insn, 16, 8);
+ op0 = extract32(insn, 16, 10);
#ifdef OPENRISC_DISAS
K16 = extract32(insn, 0, 16);
#endif
--
2.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode instructions correctly
2015-01-05 20:42 [Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode instructions correctly David Morrison
@ 2015-01-06 3:57 ` Fam Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Fam Zheng @ 2015-01-06 3:57 UTC (permalink / raw)
To: David Morrison; +Cc: qemu-trivial, peter.maydell, qemu-devel, proljc
On Mon, 01/05 12:42, David Morrison wrote:
> Fixed the decoding of "system" instructions (starting with 0x2)
> in dec_sys() in translate.c. In particular, the l.trap instruction
> is now correctly decoded, which enables for singlestepping and
> breakpoints to be set in GDB.
Missing a Signed-off-by: line here.
Fam
> ---
> target-openrisc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c
> index 407bd97..d36278f 100644
> --- a/target-openrisc/translate.c
> +++ b/target-openrisc/translate.c
> @@ -1320,7 +1320,7 @@ static void dec_sys(DisasContext *dc, uint32_t insn)
> #ifdef OPENRISC_DISAS
> uint32_t K16;
> #endif
> - op0 = extract32(insn, 16, 8);
> + op0 = extract32(insn, 16, 10);
> #ifdef OPENRISC_DISAS
> K16 = extract32(insn, 0, 16);
> #endif
> --
> 2.2.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-06 3:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-05 20:42 [Qemu-devel] [PATCH] target-openrisc: bugfix for dec_sys to decode instructions correctly David Morrison
2015-01-06 3:57 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).