From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47266)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y8RVI-0001Jm-Vq
	for qemu-devel@nongnu.org; Tue, 06 Jan 2015 05:36:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y8RVF-0004vB-PN
	for qemu-devel@nongnu.org; Tue, 06 Jan 2015 05:36:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:43031)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y8RVF-0004v1-Hx
	for qemu-devel@nongnu.org; Tue, 06 Jan 2015 05:36:45 -0500
Message-ID: <1420540596.13556.36.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Tue, 06 Jan 2015 11:36:36 +0100
In-Reply-To: <87bnmz3i4u.fsf@blackfin.pond.sub.org>
References: <1418979866-1615-1-git-send-email-kraxel@redhat.com>
	<1418979866-1615-10-git-send-email-kraxel@redhat.com>
	<87bnmz3i4u.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL 09/10] monitor: add query-vnc2 command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>, Luiz Capitulino <lcapitulino@redhat.com>


> > Add new query vnc qmp command, for the lack of better ideas just name it
> > "query-vnc2".  Changes over query-vnc:

> Call it query-vnc-servers?

Fine with me, done.

> Maybe just VncPrimaryAuth, since there's precedence for abbreviating
> authentication that way.

Done.

> >  ##
> > +# @query-vnc2:
> > +#
> > +# Returns a list of vnc servers.  The list can be empty.
> > +#
> > +# Returns: @VncInfo
> 
> Returns: a list of @VncInfo2

Yep.

While being at it and as we've dropped the '2' from the command name:
Suggestions for a better struct name?

Note there already is a VncServerInfo struct, so going for something
like VncServersInfo looks like a bad idea ...

> > +    case VNC_AUTH_SASL:
> > +        info->auth = VNC_PRI_AUTH_SASL;
> > +        break;
> > +    case VNC_AUTH_NONE:
> > +    default:
> > +        info->auth = VNC_PRI_AUTH_NONE;
> > +        break;
> > +    }
> 
> T-e-d-i-o-u-s :)
> 
> What about mapping vnc.h's authenticaton modes to the QAPI enumeration
> constants with tables rather than switches?  Your choice.

Did it this way due to the numbers being sparse.

cheers,
  Gerd