qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, mst@redhat.com, lersek@redhat.com,
	agraf@suse.de, stefanha@redhat.com, pbonzini@redhat.com,
	afaerber@suse.de, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 6/6] hw/ppc/mac_newworld: simplify usb controller creation logic
Date: Tue,  6 Jan 2015 15:29:17 +0200	[thread overview]
Message-ID: <1420550957-22337-7-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1420550957-22337-1-git-send-email-marcel@redhat.com>

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
 hw/ppc/mac_newworld.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index b54f94a..c377012 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -371,6 +371,7 @@ static void ppc_core99_init(MachineState *machine)
         /* 970 gets a U3 bus */
         pci_bus = pci_pmac_u3_init(pic, get_system_memory(), get_system_io());
         machine_arch = ARCH_MAC99_U3;
+        machine->usb |= defaults_enabled();
     } else {
         pci_bus = pci_pmac_init(pic, get_system_memory(), get_system_io());
         machine_arch = ARCH_MAC99;
@@ -417,8 +418,7 @@ static void ppc_core99_init(MachineState *machine)
     dev = qdev_create(adb_bus, TYPE_ADB_MOUSE);
     qdev_init_nofail(dev);
 
-    if ((machine_arch == ARCH_MAC99_U3 && defaults_enabled()) ||
-        usb_enabled()) {
+    if (machine->usb) {
         pci_create_simple(pci_bus, -1, "pci-ohci");
         /* U3 needs to use USB for input because Linux doesn't support via-cuda
         on PPC64 */
-- 
2.1.0

  parent reply	other threads:[~2015-01-06 13:29 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 13:29 [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 1/6] hw/ppc: modified the condition for usb controllers to be created for some ppc machines Marcel Apfelbaum
2015-01-06 21:46   ` Alexander Graf
2015-01-06 13:29 ` [Qemu-devel] [PATCH 2/6] hw/machine: added machine_usb wrapper Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 3/6] hw/usb: simplified usb_enabled Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 4/6] hw/ppc/mac_newworld: QOMified mac99 machines Marcel Apfelbaum
2015-01-06 13:29 ` [Qemu-devel] [PATCH 5/6] hw/ppc/spapr: simplify usb controller creation logic Marcel Apfelbaum
2015-01-06 20:45   ` Paolo Bonzini
2015-01-07 11:03     ` Marcel Apfelbaum
2015-01-07 11:07       ` Paolo Bonzini
2015-01-07 11:15         ` Alexander Graf
2015-01-07 11:22           ` Paolo Bonzini
2015-01-07 11:27             ` Alexander Graf
2015-01-07 11:32               ` Paolo Bonzini
2015-01-07 11:37                 ` Alexander Graf
2015-01-07 14:57                   ` Marcel Apfelbaum
2015-01-07 11:50           ` Marcel Apfelbaum
2015-01-06 13:29 ` Marcel Apfelbaum [this message]
2015-01-06 19:48 ` [Qemu-devel] [PATCH 0/6] simplify usb enabling logic and fix a Qemu crash Paolo Bonzini
2015-01-06 20:41   ` Paolo Bonzini
2015-01-06 21:54     ` Alexander Graf
2015-01-07  5:25       ` Paolo Bonzini
2015-01-07 13:15 ` Stefan Hajnoczi
2015-01-08 13:27 ` Peter Maydell
2015-01-08 16:35   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420550957-22337-7-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=lersek@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).