qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH] vl.c: fix regression when reading machine type from config file
Date: Tue,  6 Jan 2015 19:41:18 +0200	[thread overview]
Message-ID: <1420566078-27649-1-git-send-email-marcel@redhat.com> (raw)

After 'Machine as QOM' series the machine type input triggers
the creation of the machine class.
If the machine type is set in the configuration file, the machine
class is not updated accordingly and remains the default.

Fixed that by querying the machine options after the configuration
file is loaded.

Cc: qemu-stable@nongnu.org
Reported-by: William Dauchy <william@gandi.net>
Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
 vl.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/vl.c b/vl.c
index 7786b2f..ecd8c93 100644
--- a/vl.c
+++ b/vl.c
@@ -3659,6 +3659,11 @@ int main(int argc, char **argv, char **envp)
                             strerror(-ret));
                         exit(1);
                     }
+                    opts = qemu_get_machine_opts();
+                    optarg = qemu_opt_get(opts, "type");
+                    if (optarg) {
+                        machine_class = machine_parse(optarg);
+                    }
                     break;
                 }
             case QEMU_OPTION_spice:
-- 
2.1.0

             reply	other threads:[~2015-01-06 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-06 17:41 Marcel Apfelbaum [this message]
2015-01-06 19:44 ` [Qemu-devel] [PATCH] vl.c: fix regression when reading machine type from config file Paolo Bonzini
2015-01-07 10:49   ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420566078-27649-1-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).