From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, Bharata B Rao <bharata@linux.vnet.ibm.com>,
mdroth@linux.vnet.ibm.com, agraf@suse.de
Subject: [Qemu-devel] [RFC PATCH v1 07/13] spapr: Start all the threads of CPU core when core is hotplugged
Date: Thu, 8 Jan 2015 11:40:14 +0530 [thread overview]
Message-ID: <1420697420-16053-8-git-send-email-bharata@linux.vnet.ibm.com> (raw)
In-Reply-To: <1420697420-16053-1-git-send-email-bharata@linux.vnet.ibm.com>
PowerPC kernel adds or removes CPUs in core granularity and hence
onlines/offlines all the SMT threads of a core during hot plug/unplug.
Support this notion by starting all SMT threads of a core when a core
is hotplugged.
Signed-off-by: Bharata B Rao <bharata@linux.vnet.ibm.com>
---
hw/ppc/spapr.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index a293a59..4347471 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1376,6 +1376,8 @@ static void spapr_drc_reset(void *opaque)
}
}
+static const char *current_cpu_model;
+
/* pSeries LPAR / sPAPR hardware init */
static void ppc_spapr_init(MachineState *machine)
{
@@ -1473,6 +1475,8 @@ static void ppc_spapr_init(MachineState *machine)
}
}
+ current_cpu_model = cpu_model;
+
/* allocate RAM */
spapr->ram_limit = ram_size;
spapr->maxram_limit = machine->maxram_size;
@@ -1912,10 +1916,31 @@ static void spapr_cpu_plug(HotplugHandler *hotplug_dev, DeviceState *dev,
PowerPCCPU *cpu = POWERPC_CPU(cs);
sPAPRDRConnector *drc =
spapr_dr_connector_by_id(SPAPR_DR_CONNECTOR_TYPE_CPU, cpu->cpu_dt_id);
+ int id = ppc_get_vcpu_dt_id(cpu);
+ int smt = kvmppc_smt_threads();
+ int i;
+
+ /*
+ * SMT threads return from here, only main thread (core) will
+ * continue, create threads and signal hotplug event to the guest.
+ */
+ if ((id % smt) != 0) {
+ return;
+ }
/* TODO: Check if DR is enabled ? */
g_assert(drc);
+ /* Start rest of the SMT threads of the hot plugged core */
+ for (i = 1; i < smp_threads; i++) {
+ cpu = cpu_ppc_init(current_cpu_model);
+ if (cpu == NULL) {
+ fprintf(stderr, "Unable to find PowerPC CPU definition\n");
+ exit(1);
+ }
+ spapr_cpu_reset(cpu);
+ }
+
spapr_cpu_reset(POWERPC_CPU(CPU(dev)));
spapr_cpu_hotplug_add(dev, cs);
spapr_hotplug_req_add_event(drc);
--
2.1.0
next prev parent reply other threads:[~2015-01-08 6:11 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 6:10 [Qemu-devel] [RFC PATCH v1 00/13] CPU and Memory hotplug for PowerPC guests Bharata B Rao
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 01/13] spapr: enable PHB/CPU/LMB hotplug for pseries-2.3 Bharata B Rao
2015-01-22 21:08 ` Michael Roth
2015-01-29 1:04 ` David Gibson
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 02/13] spapr: Add DRC dt entries for CPUs Bharata B Rao
2015-01-22 21:21 ` Michael Roth
2015-01-29 1:04 ` David Gibson
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 03/13] spapr: Consider max_cpus during xics initialization Bharata B Rao
2015-01-29 1:05 ` David Gibson
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 04/13] spapr: Factor out CPU initialization code into realizefn Bharata B Rao
2015-01-29 1:07 ` David Gibson
2015-01-30 7:49 ` Bharata B Rao
2015-02-23 7:36 ` Bharata B Rao
2015-02-23 15:19 ` Alexander Graf
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 05/13] spapr: Support ibm, lrdr-capacity device tree property Bharata B Rao
2015-01-22 21:55 ` Michael Roth
2015-01-30 8:51 ` Bharata B Rao
2015-01-29 1:16 ` David Gibson
2015-01-30 7:50 ` Bharata B Rao
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 06/13] spapr: CPU hotplug support Bharata B Rao
2015-01-22 22:16 ` Michael Roth
2015-01-28 4:19 ` Bharata B Rao
2015-01-28 5:41 ` Michael Roth
2015-01-23 12:41 ` Igor Mammedov
2015-01-30 6:59 ` Bharata B Rao
2015-01-29 1:31 ` David Gibson
2015-01-08 6:10 ` Bharata B Rao [this message]
2015-01-29 1:36 ` [Qemu-devel] [RFC PATCH v1 07/13] spapr: Start all the threads of CPU core when core is hotplugged David Gibson
2015-01-30 8:12 ` Bharata B Rao
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 08/13] spapr: Enable CPU hotplug for POWER8 CPU family Bharata B Rao
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 09/13] spapr: CPU hot unplug support Bharata B Rao
2015-01-29 1:39 ` David Gibson
2015-01-30 8:15 ` Bharata B Rao
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 10/13] cpus, spapr: reclaim allocated vCPU objects Bharata B Rao
2015-01-29 1:48 ` David Gibson
2015-01-30 8:23 ` Bharata B Rao
2015-01-31 0:21 ` David Gibson
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 11/13] spapr: Initialize hotplug memory address space Bharata B Rao
2015-02-12 5:19 ` David Gibson
2015-02-12 5:39 ` Bharata B Rao
2015-02-16 4:56 ` David Gibson
2015-02-17 4:00 ` Bharata B Rao
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 12/13] spapr: Support ibm, dynamic-reconfiguration-memory Bharata B Rao
2015-02-12 6:02 ` David Gibson
2015-01-08 6:10 ` [Qemu-devel] [RFC PATCH v1 13/13] spapr: Memory hotplug support Bharata B Rao
2015-02-24 6:26 ` David Gibson
2015-02-24 8:12 ` Bharata B Rao
2015-01-29 17:46 ` [Qemu-devel] [RFC PATCH v1 00/13] CPU and Memory hotplug for PowerPC guests Andreas Färber
2015-02-02 9:00 ` Bharata B Rao
2015-01-29 22:14 ` Tyrel Datwyler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420697420-16053-8-git-send-email-bharata@linux.vnet.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=imammedo@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).