From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51304)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y98zk-0005YQ-5p
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 04:03:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y98zf-00069N-5t
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 04:03:08 -0500
Received: from mx1.redhat.com ([209.132.183.28]:51561)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1Y98ze-00069H-Tw
	for qemu-devel@nongnu.org; Thu, 08 Jan 2015 04:03:03 -0500
Message-ID: <1420707776.24470.15.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 08 Jan 2015 10:02:56 +0100
In-Reply-To: <67F5B5C0-41E1-4399-8A11-C3821394C31D@gmail.com>
References: <3154DC97-3B67-4DBF-BD02-C64E4A9591E3@gmail.com>
	<CAFEAcA9tShs6Uw6D5oCGWP4+Qz_OONeST5xZQB1z56kJwzKsvg@mail.gmail.com>
	<77FFD738-1433-4B15-8522-C1EA965B774B@gmail.com>
	<CAFEAcA-9duRNxzg5scTU9KGy2NP2h_MMSh=2e09vCZ0Am4_OFQ@mail.gmail.com>
	<B7EDB3C1-FEBC-4A62-9AAE-193B3EBE09E1@gmail.com>
	<CAFEAcA9LoKh=tguGA53qXrjsUGGM8PJdN9SvXHPWnMkwDhqUAQ@mail.gmail.com>
	<122C8E58-48F5-4A54-B0AF-A826492D73B6@gmail.com>
	<CAFEAcA_qEXULtxkFu3n+qrQhqVfN_b0VGRgm+=2idW8i=OZVMQ@mail.gmail.com>
	<A3473646-E4D9-4EAB-AE88-3D96074B30C7@gmail.com>
	<CAFEAcA-13UfXA=fY7ty7DFUp2RtRT947Lge3dhX+Qd6w7jwfaQ@mail.gmail.com>
	<4A37A1CE-EE81-4408-A13E-8A4C7C91D498@gmail.com>
	<54AC45AE.5020804@redhat.com>
	<CAKyx-3P-n4S-SeupjcKCi2bvCpt3csGsU=LJ=_JRqwz19x0WjA@mail.gmail.com>
	<54AD0BDE.7020200@redhat.com>
	<1420641833.27381.39.camel@nilsson.home.kraxel.org>
	<67F5B5C0-41E1-4399-8A11-C3821394C31D@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] Gives user ability to select endian format for
 video display - fixes Mac OS X guest color issue.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

  Hi,

> VGA: Using shared surface for depth=32 swap=1

Ok, 32bpp.  byteswapping needed.

I guess the host is a intel macintosh then?

Having a quick look at the cocoa code it seems it doesn't look at the
color masks and shifts, only the color depth.  So having the UI handle
the byteswapping that way isn't going to fly.

Try setting force_shadow (vga.c, needs git master) to one.  That way
vga.c will byteswap and not expect the UI to do it.  Alternatively make
cocoa UI properly handle the color masks and shifts, so non-native
ordering works.

I have some patches from benh in the pipeline allowing to negotiate
supported formats for shared buffers, with that in place hard-coded
assumptions about what formats the UI code is able to handle will go
away.  Guess I should rank them up in my priority list ;)

cheers,
  Gerd