qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Javier Celaya <javier.celaya@flexvm.es>
Cc: spice-devel <spice-devel@lists.freedesktop.org>,
	flex.dev@nologin.es, qemu-devel@nongnu.org,
	Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE
Date: Thu, 08 Jan 2015 12:28:13 +0100	[thread overview]
Message-ID: <1420716493.24470.42.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1508539.cfTQauU1Ry@javinlg>

On Do, 2015-01-08 at 11:50 +0100, Javier Celaya wrote:
> Hello
> 
> Recently, SPICE included the lz4 compression algorithm. This patch adds
> a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not 
> exist before the commit that added this compression algorithm, so it should be 
> guarded with conditional compilation. How do you think this should be done? 
> Wait for the next stable version of spice-server and check for 
> SPICE_SERVER_VERSION? Or add a specific flag?

Given that SPICE_IMAGE_COMPRESS_LZ4 is a enum not define (so you can't
just #ifdef SPICE_IMAGE_COMPRESS_LZ4) using SPICE_SERVER_VERSION looks
best to me.

cheers,
  Gerd

  reply	other threads:[~2015-01-08 11:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 10:50 [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE Javier Celaya
2015-01-08 11:28 ` Gerd Hoffmann [this message]
2015-01-08 11:48 ` [Qemu-devel] [Spice-devel] " Fabio Fantoni
2015-01-08 12:00   ` Javier Celaya
2015-01-20 16:08 ` Christophe Fergeau
2015-01-23 14:06   ` Javier Celaya
2015-01-23 16:25     ` Eric Blake
2015-01-26  8:48       ` Javier Celaya
2015-01-26 16:25         ` Eric Blake
2015-01-27  8:26           ` Markus Armbruster
2015-01-28 16:54             ` Javier Celaya
2015-01-28 19:08               ` Markus Armbruster
2015-07-24 14:12             ` Fabio Fantoni
2015-07-27  6:12               ` Markus Armbruster
2015-10-09  6:45             ` Fabio Fantoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1420716493.24470.42.camel@nilsson.home.kraxel.org \
    --to=kraxel@redhat.com \
    --cc=aliguori@amazon.com \
    --cc=flex.dev@nologin.es \
    --cc=javier.celaya@flexvm.es \
    --cc=qemu-devel@nongnu.org \
    --cc=spice-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).