From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54665) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9BGk-0002ac-S5 for qemu-devel@nongnu.org; Thu, 08 Jan 2015 06:28:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9BGh-0005dC-LY for qemu-devel@nongnu.org; Thu, 08 Jan 2015 06:28:50 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57597) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9BGh-0005d2-Ee for qemu-devel@nongnu.org; Thu, 08 Jan 2015 06:28:47 -0500 Message-ID: <1420716493.24470.42.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 08 Jan 2015 12:28:13 +0100 In-Reply-To: <1508539.cfTQauU1Ry@javinlg> References: <1508539.cfTQauU1Ry@javinlg> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] [RFC] LZ4 compression option for SPICE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Javier Celaya Cc: spice-devel , flex.dev@nologin.es, qemu-devel@nongnu.org, Anthony Liguori On Do, 2015-01-08 at 11:50 +0100, Javier Celaya wrote: > Hello > > Recently, SPICE included the lz4 compression algorithm. This patch adds > a command line option to select it. However, SPICE_IMAGE_COMPRESS_LZ4 did not > exist before the commit that added this compression algorithm, so it should be > guarded with conditional compilation. How do you think this should be done? > Wait for the next stable version of spice-server and check for > SPICE_SERVER_VERSION? Or add a specific flag? Given that SPICE_IMAGE_COMPRESS_LZ4 is a enum not define (so you can't just #ifdef SPICE_IMAGE_COMPRESS_LZ4) using SPICE_SERVER_VERSION looks best to me. cheers, Gerd