From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Gzn-0003vS-JQ for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:35:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9Gze-0006e0-QN for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:35:43 -0500 Received: from e39.co.us.ibm.com ([32.97.110.160]:44552) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Gzd-0006d8-DU for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:35:33 -0500 Received: from /spool/local by e39.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Jan 2015 10:35:32 -0700 From: Michael Roth Date: Thu, 8 Jan 2015 11:33:46 -0600 Message-Id: <1420738472-23267-43-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1420738472-23267-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1420738472-23267-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 42/88] vmware-vga: CVE-2014-3689: turn off hw accel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: Gerd Hoffmann Quick & easy stopgap for CVE-2014-3689: We just compile out the hardware acceleration functions which lack sanity checks. Thankfully we have capability bits for them (SVGA_CAP_RECT_COPY and SVGA_CAP_RECT_FILL), so guests should deal just fine, in theory. Subsequent patches will add the missing checks and re-enable the hardware acceleration emulation. Cc: qemu-stable@nongnu.org Signed-off-by: Gerd Hoffmann Reviewed-by: Don Koch (cherry picked from commit 83afa38eb20ca27e30683edc7729880e091387fc) Signed-off-by: Michael Roth --- hw/display/vmware_vga.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 591b645..4a4229b 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -29,8 +29,10 @@ #include "hw/pci/pci.h" #undef VERBOSE +#if 0 #define HW_RECT_ACCEL #define HW_FILL_ACCEL +#endif #define HW_MOUSE_ACCEL #include "vga_int.h" -- 1.9.1