From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Gzz-0004Ay-FZ for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:36:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9Gzl-0006jY-5z for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:35:55 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:46543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Gzl-0006j2-0d for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:35:41 -0500 Received: from /spool/local by e9.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Jan 2015 12:35:40 -0500 From: Michael Roth Date: Thu, 8 Jan 2015 11:33:56 -0600 Message-Id: <1420738472-23267-53-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1420738472-23267-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1420738472-23267-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 52/88] tcg/mips: fix store softmmu slow path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: Aurelien Jarno Commit 9d8bf2d1 moved the softmmu slow path out of line and introduce a regression at the same time by always calling tcg_out_tlb_load with is_load=1. This makes impossible to run any significant code under qemu-system-mips*. Cc: Paolo Bonzini Cc: qemu-stable@nongnu.org Reviewed-by: Richard Henderson Signed-off-by: Aurelien Jarno (cherry picked from commit 0a2923f8488498000eec54871456aa64a4391da4) Signed-off-by: Michael Roth --- tcg/mips/tcg-target.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/mips/tcg-target.c b/tcg/mips/tcg-target.c index 9cce356..b7f4d67 100644 --- a/tcg/mips/tcg-target.c +++ b/tcg/mips/tcg-target.c @@ -1302,7 +1302,7 @@ static void tcg_out_qemu_st(TCGContext *s, const TCGArg *args, bool is_64) so we can reuse that for the base. */ base = (TARGET_LONG_BITS == 32 ? TCG_REG_A1 : TCG_REG_A2); tcg_out_tlb_load(s, base, addr_regl, addr_regh, mem_index, - s_bits, label_ptr, 1); + s_bits, label_ptr, 0); tcg_out_qemu_st_direct(s, data_regl, data_regh, base, opc); add_qemu_ldst_label(s, 0, opc, data_regl, data_regh, addr_regl, addr_regh, mem_index, s->code_ptr, label_ptr); -- 1.9.1