From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60695) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9H0C-0004Ws-Gb for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:36:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Y9Gzs-0006pY-Pr for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:36:08 -0500 Received: from e7.ny.us.ibm.com ([32.97.182.137]:55107) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Y9Gzs-0006pL-LG for qemu-devel@nongnu.org; Thu, 08 Jan 2015 12:35:48 -0500 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 8 Jan 2015 12:35:48 -0500 From: Michael Roth Date: Thu, 8 Jan 2015 11:34:05 -0600 Message-Id: <1420738472-23267-62-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1420738472-23267-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1420738472-23267-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 61/88] libcacard: fix resource leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-stable@nongnu.org From: zhanghailiang In function connect_to_qemu(), getaddrinfo() will allocate memory that is stored into server, it should be freed by using freeaddrinfo() before connect_to_qemu() return. Cc: qemu-stable@nongnu.org Reviewed-by: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Paolo Bonzini (cherry picked from commit 5bbebf622897a59db5da4c468e737bfec4d71280) Signed-off-by: Michael Roth --- libcacard/vscclient.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c index 80111df..fa6041d 100644 --- a/libcacard/vscclient.c +++ b/libcacard/vscclient.c @@ -597,7 +597,7 @@ connect_to_qemu( const char *port ) { struct addrinfo hints; - struct addrinfo *server; + struct addrinfo *server = NULL; int ret, sock; sock = socket(AF_INET, SOCK_STREAM, 0); @@ -629,9 +629,14 @@ connect_to_qemu( if (verbose) { printf("Connected (sizeof Header=%zd)!\n", sizeof(VSCMsgHeader)); } + + freeaddrinfo(server); return sock; cleanup_socket: + if (server) { + freeaddrinfo(server); + } closesocket(sock); return -1; } -- 1.9.1