From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Anthony Liguori <aliguori@amazon.com>
Subject: [Qemu-devel] [PATCH 1/8] ui: Make qemu_default_pixman_format() return 0 on unsupported formats
Date: Fri, 9 Jan 2015 10:28:30 +0100 [thread overview]
Message-ID: <1420795717-28966-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1420795717-28966-1-git-send-email-kraxel@redhat.com>
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
In order to remove the logic for detecting supported shared
pixmap formats from device models, make qemu_default_pixman_format()
capable for failing by returning 0 which is not a possible format
value rather than asserting.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
ui/qemu-pixman.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/qemu-pixman.c b/ui/qemu-pixman.c
index 1f6fea5..6a889e9 100644
--- a/ui/qemu-pixman.c
+++ b/ui/qemu-pixman.c
@@ -84,7 +84,7 @@ pixman_format_code_t qemu_default_pixman_format(int bpp, bool native_endian)
break;
}
}
- g_assert_not_reached();
+ return 0;
}
int qemu_pixman_get_type(int rshift, int gshift, int bshift)
--
1.8.3.1
next prev parent reply other threads:[~2015-01-09 9:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 9:28 [Qemu-devel] [PATCH 0/8] ui/console: add format negotiation for shared surfaces Gerd Hoffmann
2015-01-09 9:28 ` Gerd Hoffmann [this message]
2015-01-09 9:28 ` [Qemu-devel] [PATCH 2/8] ui: Add dpy_gfx_check_format() to check backend shared surface support Gerd Hoffmann
2015-01-09 9:28 ` [Qemu-devel] [PATCH 3/8] ui/pixman: add qemu_pixman_check_format Gerd Hoffmann
2015-01-09 9:28 ` [Qemu-devel] [PATCH 4/8] ui/vnc: Support shared surface for most pixman formats Gerd Hoffmann
2015-01-09 9:28 ` [Qemu-devel] [PATCH 5/8] ui/spice: " Gerd Hoffmann
2015-01-09 9:28 ` [Qemu-devel] [PATCH 6/8] ui/gtk: " Gerd Hoffmann
2015-01-09 9:28 ` [Qemu-devel] [PATCH 7/8] ui/sdl: Support shared surface for more " Gerd Hoffmann
2015-01-09 9:28 ` [Qemu-devel] [PATCH 8/8] ui/sdl2: " Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420795717-28966-2-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).