From: Frediano Ziglio <freddy77@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@amazon.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Frediano Ziglio <frediano.ziglio@huawei.com>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/2] qemu-common.h: optimise muldiv64 if int128 is available
Date: Fri, 9 Jan 2015 11:25:20 +0000 [thread overview]
Message-ID: <1420802721-14457-1-git-send-email-frediano.ziglio@huawei.com> (raw)
Let compiler do the job to optimise the function.
Signed-off-by: Frediano Ziglio <frediano.ziglio@huawei.com>
---
include/qemu-common.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/qemu-common.h b/include/qemu-common.h
index f862214..f3033ae 100644
--- a/include/qemu-common.h
+++ b/include/qemu-common.h
@@ -370,6 +370,12 @@ static inline uint8_t from_bcd(uint8_t val)
}
/* compute with 96 bit intermediate result: (a*b)/c */
+#ifdef CONFIG_INT128
+static inline uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)
+{
+ return (__int128)a * b / c;
+}
+#else
static inline uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)
{
union {
@@ -392,6 +398,7 @@ static inline uint64_t muldiv64(uint64_t a, uint32_t b, uint32_t c)
res.l.low = (((rh % c) << 32) + (rl & 0xffffffff)) / c;
return res.ll;
}
+#endif
/* Round number down to multiple */
#define QEMU_ALIGN_DOWN(n, m) ((n) / (m) * (m))
--
1.9.1
next reply other threads:[~2015-01-09 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-09 11:25 Frediano Ziglio [this message]
2015-01-09 11:25 ` [Qemu-devel] [PATCH 2/2] qemu-common.h: optimise muldiv64 for x86_64 architecture Frediano Ziglio
2015-01-09 11:43 ` Paolo Bonzini
2015-01-09 12:09 ` Frediano Ziglio
2015-01-09 12:22 ` Peter Maydell
2015-01-09 15:41 ` Frediano Ziglio
2015-01-09 15:52 ` Peter Maydell
2015-01-09 16:08 ` Frediano Ziglio
2015-01-09 16:10 ` Peter Maydell
2015-01-09 12:03 ` [Qemu-devel] [PATCH 1/2] qemu-common.h: optimise muldiv64 if int128 is available Peter Maydell
2015-01-09 13:43 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420802721-14457-1-git-send-email-frediano.ziglio@huawei.com \
--to=freddy77@gmail.com \
--cc=aliguori@amazon.com \
--cc=frediano.ziglio@huawei.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).