From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42406)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YAb3m-0001d1-O0
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 04:13:19 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YAb3h-0006GF-Pu
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 04:13:18 -0500
Received: from mx1.redhat.com ([209.132.183.28]:46272)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1YAb3h-0006Fs-I6
	for qemu-devel@nongnu.org; Mon, 12 Jan 2015 04:13:13 -0500
Message-ID: <1421053976.8695.13.camel@nilsson.home.kraxel.org>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Mon, 12 Jan 2015 10:12:56 +0100
In-Reply-To: <1F47539E-5ACE-4AFD-956B-266FAA04098D@gmail.com>
References: <3154DC97-3B67-4DBF-BD02-C64E4A9591E3@gmail.com>
	<CAFEAcA9tShs6Uw6D5oCGWP4+Qz_OONeST5xZQB1z56kJwzKsvg@mail.gmail.com>
	<77FFD738-1433-4B15-8522-C1EA965B774B@gmail.com>
	<CAFEAcA-9duRNxzg5scTU9KGy2NP2h_MMSh=2e09vCZ0Am4_OFQ@mail.gmail.com>
	<B7EDB3C1-FEBC-4A62-9AAE-193B3EBE09E1@gmail.com>
	<CAFEAcA9LoKh=tguGA53qXrjsUGGM8PJdN9SvXHPWnMkwDhqUAQ@mail.gmail.com>
	<122C8E58-48F5-4A54-B0AF-A826492D73B6@gmail.com>
	<CAFEAcA_qEXULtxkFu3n+qrQhqVfN_b0VGRgm+=2idW8i=OZVMQ@mail.gmail.com>
	<A3473646-E4D9-4EAB-AE88-3D96074B30C7@gmail.com>
	<CAFEAcA-13UfXA=fY7ty7DFUp2RtRT947Lge3dhX+Qd6w7jwfaQ@mail.gmail.com>
	<4A37A1CE-EE81-4408-A13E-8A4C7C91D498@gmail.com>
	<54AC45AE.5020804@redhat.com>
	<CAKyx-3P-n4S-SeupjcKCi2bvCpt3csGsU=LJ=_JRqwz19x0WjA@mail.gmail.com>
	<54AD0BDE.7020200@redhat.com>
	<1420641833.27381.39.camel@nilsson.home.kraxel.org>
	<67F5B5C0-41E1-4399-8A11-C3821394C31D@gmail.com>
	<1420707776.24470.15.camel@nilsson.home.kraxel.org>
	<07B03389-9719-42C2-A561-05347C36D947@gmail.com>
	<1420793910.24278.6.camel@nilsson.home.kraxel.org>
	<1F47539E-5ACE-4AFD-956B-266FAA04098D@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2] Gives user ability to select endian
 format for video display - fixes Mac OS X guest color issue.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Programmingkid <programmingkidx@gmail.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel qemu-devel <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

  Hi,

> +    /* Determines the pixel format of the frame buffer */
> +    if (surface->format == PIXMAN_b8g8r8x8) {
> +        bitmap_info = kCGBitmapByteOrder32Big | kCGImageAlphaNoneSkipFirst;
> +    }

That certainly goes into the right direction.

PIXMAN_* is native endian though, so I expect this will work on the
intel macos host you are testing on but will fail on powerpc macos
hosts.

I suggest to add fixed endian defines for 32bpp to
include/ui/qemu-pixman.h (there already is one for 24bpp), then use
these to avoid cluttering the cocoa code with HOST_WORDS_BIGENDIAN
#defines.

The colorspace bits look sane to me, I'm not macos x expert enough to
really justify.

cheers,
  Gerd