From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAbrv-0002vG-Vl for qemu-devel@nongnu.org; Mon, 12 Jan 2015 05:05:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YAbrp-0005lq-3R for qemu-devel@nongnu.org; Mon, 12 Jan 2015 05:05:07 -0500 Received: from e06smtp11.uk.ibm.com ([195.75.94.107]:36631) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YAbro-0005lN-Pm for qemu-devel@nongnu.org; Mon, 12 Jan 2015 05:05:01 -0500 Received: from /spool/local by e06smtp11.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 12 Jan 2015 10:04:58 -0000 Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 46044219004D for ; Mon, 12 Jan 2015 10:04:25 +0000 (GMT) Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com [9.149.37.217]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t0CA4vjF56426668 for ; Mon, 12 Jan 2015 10:04:57 GMT Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t0C517Og006205 for ; Mon, 12 Jan 2015 00:01:08 -0500 From: Cornelia Huck Date: Mon, 12 Jan 2015 11:04:46 +0100 Message-Id: <1421057092-8415-2-git-send-email-cornelia.huck@de.ibm.com> In-Reply-To: <1421057092-8415-1-git-send-email-cornelia.huck@de.ibm.com> References: <1421057092-8415-1-git-send-email-cornelia.huck@de.ibm.com> Subject: [Qemu-devel] [PULL v3 1/7] s390x/ccw: fix oddity in machine class init List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org Cc: Cornelia Huck , borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, qemu-devel@nongnu.org, agraf@suse.de ccw_machine_class_init() uses ',' instead of ';' while initializing the class' fields. This is almost certainly a copy/paste error and, while legal C, rather on the unusual side. Just use ';' everywhere. Reviewed-by: Thomas Huth Signed-off-by: Cornelia Huck Signed-off-by: Jens Freimann Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index bc4dc2a..f7b750d 100644 --- a/hw/s390x/s390-virtio-ccw.c +++ b/hw/s390x/s390-virtio-ccw.c @@ -181,7 +181,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data) mc->no_serial = 1; mc->no_parallel = 1; mc->no_sdcard = 1; - mc->use_sclp = 1, + mc->use_sclp = 1; mc->max_cpus = 255; nc->nmi_monitor_handler = s390_nmi; } -- 1.7.9.5