From: Stefan Hajnoczi <stefanha@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL v2 36/44] coroutine: drop qemu_coroutine_adjust_pool_size
Date: Mon, 12 Jan 2015 16:40:26 +0000 [thread overview]
Message-ID: <1421080834-14724-37-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1421080834-14724-1-git-send-email-stefanha@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
This is not needed anymore. The new TLS-based algorithm is adaptive.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Message-id: 1417518350-6167-7-git-send-email-pbonzini@redhat.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
block/block-backend.c | 4 ----
include/block/coroutine.h | 10 ----------
qemu-coroutine.c | 4 ----
3 files changed, 18 deletions(-)
diff --git a/block/block-backend.c b/block/block-backend.c
index ef16d73..d00c129 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -260,9 +260,6 @@ int blk_attach_dev(BlockBackend *blk, void *dev)
blk_ref(blk);
blk->dev = dev;
bdrv_iostatus_reset(blk->bs);
-
- /* We're expecting I/O from the device so bump up coroutine pool size */
- qemu_coroutine_adjust_pool_size(COROUTINE_POOL_RESERVATION);
return 0;
}
@@ -290,7 +287,6 @@ void blk_detach_dev(BlockBackend *blk, void *dev)
blk->dev_ops = NULL;
blk->dev_opaque = NULL;
bdrv_set_guest_block_size(blk->bs, 512);
- qemu_coroutine_adjust_pool_size(-COROUTINE_POOL_RESERVATION);
blk_unref(blk);
}
diff --git a/include/block/coroutine.h b/include/block/coroutine.h
index 793df0e..20c027a 100644
--- a/include/block/coroutine.h
+++ b/include/block/coroutine.h
@@ -216,14 +216,4 @@ void coroutine_fn co_aio_sleep_ns(AioContext *ctx, QEMUClockType type,
*/
void coroutine_fn yield_until_fd_readable(int fd);
-/**
- * Add or subtract from the coroutine pool size
- *
- * The coroutine implementation keeps a pool of coroutines to be reused by
- * qemu_coroutine_create(). This makes coroutine creation cheap. Heavy
- * coroutine users should call this to reserve pool space. Call it again with
- * a negative number to release pool space.
- */
-void qemu_coroutine_adjust_pool_size(int n);
-
#endif /* QEMU_COROUTINE_H */
diff --git a/qemu-coroutine.c b/qemu-coroutine.c
index 93fddc7..da1b961 100644
--- a/qemu-coroutine.c
+++ b/qemu-coroutine.c
@@ -143,7 +143,3 @@ void coroutine_fn qemu_coroutine_yield(void)
self->caller = NULL;
coroutine_swap(self, to);
}
-
-void qemu_coroutine_adjust_pool_size(int n)
-{
-}
--
2.1.0
next prev parent reply other threads:[~2015-01-12 16:43 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 16:39 [Qemu-devel] [PULL v2 00/44] Block patches Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 01/44] qemu-iotests: Remove 091 from quick group Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 02/44] qemu-iotests: Speed up make check-block Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 03/44] block: mark AioContext as recursive Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 04/44] block: do not allocate an iovec per read of a growable/zero_after_eof BDS Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 05/44] block: replace g_new0 with g_new for bottom half allocation Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 06/44] checkpatch: Brace handling on multi-line condition Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 07/44] block: Get full backing filename from string Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 08/44] block: JSON filenames and relative backing files Stefan Hajnoczi
2015-01-12 16:39 ` [Qemu-devel] [PULL v2 09/44] block: Relative backing file for image creation Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 10/44] block/vmdk: Relative backing file for creation Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 11/44] iotests: Add test for relative backing file names Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 12/44] qapi: Fix document for BlockStats.node-name Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 13/44] block: fix spoiling all dirty bitmaps by mirror and migration Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 14/44] qapi: Comment version info in TransactionAction Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 15/44] qmp: Add command 'blockdev-backup' Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 16/44] block: Add blockdev-backup to transaction Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 17/44] qemu-iotests: Test blockdev-backup in 055 Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 18/44] iotests: Filter out "I/O thread spun..." warning Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 19/44] migration/block: fix pending() return value Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 20/44] libqos: Convert malloc-pc allocator to a generic allocator Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 21/44] libqos: Change use of pointers to uint64_t in virtio Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 22/44] tests: Prepare virtio-blk-test for multi-arch implementation Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 23/44] libqos: Remove PCI assumptions in constants of virtio driver Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 24/44] libqos: Add malloc generic Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 25/44] libqos: Add virtio MMIO support Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 26/44] block/raw-posix.c: Fixes raw_getlength() on Mac OS X so that it reports the correct length of a real CD Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 27/44] .gitignore: Ignore generated "common.env" Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 28/44] qemu-iotests: Replace "/bin/true" with "true" Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 29/44] qemu-iotests: Add "_supported_os Linux" to 058 Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 30/44] qemu-iotests: Add supported os parameter for python tests Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 31/44] coroutine-ucontext: use __thread Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 32/44] qemu-thread: add per-thread atexit functions Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 33/44] test-coroutine: avoid overflow on 32-bit systems Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 34/44] QSLIST: add lock-free operations Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 35/44] coroutine: rewrite pool to avoid mutex Stefan Hajnoczi
2015-01-12 16:40 ` Stefan Hajnoczi [this message]
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 37/44] coroutine: try harder not to delete coroutines Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 38/44] block: limited request size in write zeroes unsupported path Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 39/44] block: Split BLOCK_OP_TYPE_COMMIT to BLOCK_OP_TYPE_COMMIT_{SOURCE, TARGET} Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 40/44] ide: Implement VPD response for ATAPI Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 41/44] nvme: Fix get/set number of queues feature Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 42/44] MAINTAINERS: Update email addresses for Chrysostomos Nanakos Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 43/44] MAINTAINERS: Add migration/block* to block subsystem Stefan Hajnoczi
2015-01-12 16:40 ` [Qemu-devel] [PULL v2 44/44] NVMe: Set correct VS Value for 1.1 Compliant Controllers Stefan Hajnoczi
2015-01-12 21:43 ` [Qemu-devel] [PULL v2 00/44] Block patches Peter Maydell
2015-01-13 13:19 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421080834-14724-37-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).