From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 04/15] vl: Avoid unnecessary 'if' nesting
Date: Wed, 14 Jan 2015 10:41:21 +0100 [thread overview]
Message-ID: <1421228492-19856-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1421228492-19856-1-git-send-email-pbonzini@redhat.com>
From: Eduardo Habkost <ehabkost@redhat.com>
Just a coding style change, to make other changes easier to review.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index 1a2da2b..56a17dd 100644
--- a/vl.c
+++ b/vl.c
@@ -1170,13 +1170,11 @@ static void smp_parse(QemuOpts *opts)
if (cpus == 0) {
cpus = cores * threads * sockets;
}
+ } else if (cores == 0) {
+ threads = threads > 0 ? threads : 1;
+ cores = cpus / (sockets * threads);
} else {
- if (cores == 0) {
- threads = threads > 0 ? threads : 1;
- cores = cpus / (sockets * threads);
- } else {
- threads = cpus / (cores * sockets);
- }
+ threads = cpus / (cores * sockets);
}
max_cpus = qemu_opt_get_number(opts, "maxcpus", 0);
--
1.8.3.1
next prev parent reply other threads:[~2015-01-14 9:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 9:41 [Qemu-devel] [PULL 00/15] Misc patches for 2015-01-14 Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 01/15] char: restore stdio echo on resume from suspend Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 02/15] vl.c: fix regression when reading machine type from config file Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 03/15] 9pfs: changed to use event_notifier instead of qemu_pipe Paolo Bonzini
2015-01-14 9:41 ` Paolo Bonzini [this message]
2015-01-14 9:41 ` [Qemu-devel] [PULL 05/15] vl: fix max_cpus check Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 06/15] vl: Don't silently change topology when all -smp options were set Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 07/15] vl.c: fix regression when reading memory size from config file Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 08/15] target-i386: fix movntsd on big-endian hosts Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 09/15] target-i386: do not memcpy in and out of xmm_regs Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 10/15] qemu-common.h: optimise muldiv64 if int128 is available Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 11/15] hw/scsi/lsi53c895a: add support for additional diag / debug registers Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 12/15] rules.mak: Fix module build Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 13/15] scsi: fix cancellation when I/O was completed but DMA was not Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 14/15] qemu-timer: rename timer_init to timer_init_tl Paolo Bonzini
2015-01-14 9:41 ` [Qemu-devel] [PULL 15/15] cpus: consistently use QEMU_CLOCK_VIRTUAL_RT for icount_warp_rt timer Paolo Bonzini
2015-01-14 20:24 ` [Qemu-devel] [PULL 00/15] Misc patches for 2015-01-14 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421228492-19856-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=ehabkost@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).