* [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity
@ 2015-01-14 15:20 Frank Blaschka
2015-01-14 16:59 ` Thomas Huth
2015-01-16 9:21 ` Cornelia Huck
0 siblings, 2 replies; 3+ messages in thread
From: Frank Blaschka @ 2015-01-14 15:20 UTC (permalink / raw)
To: cornelia.huck, borntraeger, pbonzini; +Cc: Frank Blaschka, qemu-devel
Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
---
hw/s390x/s390-pci-bus.c | 1 +
hw/s390x/s390-pci-inst.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index 1201b8d..546dcf1 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -192,6 +192,7 @@ static void s390_pci_generate_event(uint8_t cc, uint16_t pec, uint32_t fh,
object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL));
if (!s) {
+ g_free(sei_cont);
return;
}
diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
index 5ea13e5..5596679 100644
--- a/hw/s390x/s390-pci-inst.c
+++ b/hw/s390x/s390-pci-inst.c
@@ -787,7 +787,7 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba)
data = (pbdev->isc << 28) | (pbdev->noi << 16) |
(pbdev->routes.adapter.ind_offset << 8) | (pbdev->sum << 7) |
pbdev->routes.adapter.summary_offset;
- stw_p(&fib.data, data);
+ stl_p(&fib.data, data);
if (pbdev->fh >> ENABLE_BIT_OFFSET) {
fib.fc |= 0x80;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity
2015-01-14 15:20 [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity Frank Blaschka
@ 2015-01-14 16:59 ` Thomas Huth
2015-01-16 9:21 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2015-01-14 16:59 UTC (permalink / raw)
To: Frank Blaschka; +Cc: cornelia.huck, borntraeger, qemu-devel, pbonzini
On Wed, 14 Jan 2015 16:20:47 +0100
Frank Blaschka <blaschka@linux.vnet.ibm.com> wrote:
> Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
> ---
> hw/s390x/s390-pci-bus.c | 1 +
> hw/s390x/s390-pci-inst.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
> index 1201b8d..546dcf1 100644
> --- a/hw/s390x/s390-pci-bus.c
> +++ b/hw/s390x/s390-pci-bus.c
> @@ -192,6 +192,7 @@ static void s390_pci_generate_event(uint8_t cc, uint16_t pec, uint32_t fh,
> object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL));
>
> if (!s) {
> + g_free(sei_cont);
> return;
> }
>
> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
> index 5ea13e5..5596679 100644
> --- a/hw/s390x/s390-pci-inst.c
> +++ b/hw/s390x/s390-pci-inst.c
> @@ -787,7 +787,7 @@ int stpcifc_service_call(S390CPU *cpu, uint8_t r1, uint64_t fiba)
> data = (pbdev->isc << 28) | (pbdev->noi << 16) |
> (pbdev->routes.adapter.ind_offset << 8) | (pbdev->sum << 7) |
> pbdev->routes.adapter.summary_offset;
> - stw_p(&fib.data, data);
> + stl_p(&fib.data, data);
>
> if (pbdev->fh >> ENABLE_BIT_OFFSET) {
> fib.fc |= 0x80;
Looks right.
Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity
2015-01-14 15:20 [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity Frank Blaschka
2015-01-14 16:59 ` Thomas Huth
@ 2015-01-16 9:21 ` Cornelia Huck
1 sibling, 0 replies; 3+ messages in thread
From: Cornelia Huck @ 2015-01-16 9:21 UTC (permalink / raw)
To: Frank Blaschka; +Cc: borntraeger, qemu-devel, pbonzini
On Wed, 14 Jan 2015 16:20:47 +0100
Frank Blaschka <blaschka@linux.vnet.ibm.com> wrote:
> Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
> ---
> hw/s390x/s390-pci-bus.c | 1 +
> hw/s390x/s390-pci-inst.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
Applied with a slightly tweaked description:
s390x/pci: fix two bugs found by coverity
Fix a resource leak and a store with the wrong length.
Reviewed-by: Thomas Huth <thuth@linux.vnet.ibm.com>
Signed-off-by: Frank Blaschka <blaschka@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-16 9:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-14 15:20 [Qemu-devel] [PATCH] s390x/pci: fix 2 bugs found by coverity Frank Blaschka
2015-01-14 16:59 ` Thomas Huth
2015-01-16 9:21 ` Cornelia Huck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).