From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBm8e-0004GP-7u for qemu-devel@nongnu.org; Thu, 15 Jan 2015 10:15:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YBm8W-0003eY-Fm for qemu-devel@nongnu.org; Thu, 15 Jan 2015 10:15:12 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:54864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YBm8W-0003XX-8u for qemu-devel@nongnu.org; Thu, 15 Jan 2015 10:15:04 -0500 From: Peter Maydell Date: Thu, 15 Jan 2015 15:01:43 +0000 Message-Id: <1421334118-3287-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH 00/15] Clean up cpu-ldst ld/st memory accessors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , Riku Voipio , Richard Henderson , patches@linaro.org I was looking at our confusing mess of memory accessor functions, and I realised that partly it was confusing because we have a bunch of unnecessary junk lurking in there :-) This series attempts to clean things up by removing things we weren't using at all or were only using by mistake in a few places: * ldul_*: not used * ld* (ldl, etc): hardly used * ld*_kernel: not used * ld*_raw: hardly used * cpu_{ld,st}{fq,fl}: not used The dull parts of this series are removing the unused macros and fixing uses of the hardly-used macros so those can be deleted too. This series also switches to using inline functions rather than macros for the user-only cpu_ld/st* accessors, bringing them into line with the softmmu configs. This has the nice side effect of letting us get rid of the _raw accessor macros too. I've also thrown in a commit which cleans up the doc comments. Peter Maydell (15): cpu_ldst.h: Remove unused ldul_ macros monitor.c: Use ld*_p() instead of ld*_raw() target-sparc: Don't use {ld,st}*_raw functions linux-user/elfload.c: Don't use _raw accessor functions bsd-user/elfload.c: Don't use ldl() or ldq_raw() linux-user/vm86.c: Use cpu_ldl_data &c rather than plain ldl &c linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop target-mips: Don't use _raw load/store accessors cpu_ldst.h: Drop unused ld/st*_kernel defines cpu_ldst.h: Remove unused very short ld*/st* defines cpu_ldst.h: Use inline functions for usermode cpu_ld/st accessors cpu_ldst_template.h: Use ld*_p directly rather than via ld*_raw macros cpu_ldst.h: Drop unused _raw macros, saddr() and laddr() cpu_ldst_template.h: Drop unused cpu_ldfq/stfq/ldfl/stfl accessors cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st accessors bsd-user/elfload.c | 11 +- include/exec/cpu-all.h | 38 +------ include/exec/cpu_ldst.h | 162 +++++++++--------------------- include/exec/cpu_ldst_template.h | 60 +---------- include/exec/cpu_ldst_useronly_template.h | 81 +++++++++++++++ include/qemu/bswap.h | 11 +- linux-user/elfload.c | 7 +- linux-user/main.c | 2 +- linux-user/vm86.c | 57 ++++++----- monitor.c | 8 +- target-i386/seg_helper.c | 16 ++- target-mips/op_helper.c | 4 +- target-sparc/ldst_helper.c | 24 ++--- 13 files changed, 224 insertions(+), 257 deletions(-) create mode 100644 include/exec/cpu_ldst_useronly_template.h -- 1.9.1