qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH v5 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp
Date: Fri, 16 Jan 2015 16:46:22 +0800	[thread overview]
Message-ID: <1421397983-28065-5-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1421397983-28065-1-git-send-email-famz@redhat.com>

QMP command "block_set_io_throttle" expects underscores in parameters
instead of dashes: {iops,bps}_{rd,wr,max}.

Add optional argument conv_keys (defaults to True, backward compatible),
it will be used in IO throttling test case.

Reviewed-by: Benoit Canet <benoit@irqsave.net>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/qemu-iotests/iotests.py | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 85cb9a5..1402854 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -185,11 +185,14 @@ class VM(object):
             self._popen = None
 
     underscore_to_dash = string.maketrans('_', '-')
-    def qmp(self, cmd, **args):
+    def qmp(self, cmd, conv_keys=True, **args):
         '''Invoke a QMP command and return the result dict'''
         qmp_args = dict()
         for k in args.keys():
-            qmp_args[k.translate(self.underscore_to_dash)] = args[k]
+            if conv_keys:
+                qmp_args[k.translate(self.underscore_to_dash)] = args[k]
+            else:
+                qmp_args[k] = args[k]
 
         return self._qmp.cmd(cmd, args=qmp_args)
 
-- 
1.9.3

  parent reply	other threads:[~2015-01-16  8:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-16  8:46 [Qemu-devel] [PATCH v5 0/5] block: Add a qemu-iotests case for IO throttling Fam Zheng
2015-01-16  8:46 ` [Qemu-devel] [PATCH v5 1/5] qemu-io: Account IO by aio_read and aio_write Fam Zheng
2015-01-26 20:19   ` Max Reitz
2015-01-16  8:46 ` [Qemu-devel] [PATCH v5 2/5] qtest: Add scripts/qtest.py Fam Zheng
2015-01-26 20:22   ` Max Reitz
2015-01-16  8:46 ` [Qemu-devel] [PATCH v5 3/5] qemu-iotests: Add VM method qtest() to iotests.py Fam Zheng
2015-01-26 20:26   ` Max Reitz
2015-01-16  8:46 ` Fam Zheng [this message]
2015-01-26 20:27   ` [Qemu-devel] [PATCH v5 4/5] qemu-iotests: Allow caller to disable underscore convertion for qmp Max Reitz
2015-01-16  8:46 ` [Qemu-devel] [PATCH v5 5/5] qemu-iotests: Add 093 for IO throttling Fam Zheng
2015-01-26 20:45   ` Max Reitz
2015-01-27  3:03     ` Fam Zheng
2015-01-27 16:14       ` Max Reitz
2015-01-28  1:59         ` Fam Zheng
2015-01-28 11:11           ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421397983-28065-5-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).