From: sfeldma@gmail.com
To: qemu-devel@nongnu.org, jiri@resnulli.us,
roopa@cumulusnetworks.com, john.fastabend@gmail.com,
eblake@redhat.com, pbonzini@redhat.com, stefanha@gmail.com,
dsahern@gmail.com
Subject: [Qemu-devel] [PATCH v4 02/10] virtio-net: use qemu_mac_strdup_printf
Date: Fri, 16 Jan 2015 00:51:26 -0800 [thread overview]
Message-ID: <1421398294-22035-3-git-send-email-sfeldma@gmail.com> (raw)
In-Reply-To: <1421398294-22035-1-git-send-email-sfeldma@gmail.com>
From: Scott Feldman <sfeldma@gmail.com>
Signed-off-by: Scott Feldman <sfeldma@gmail.com>
---
hw/net/virtio-net.c | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 45da34a..698156f 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -226,12 +226,6 @@ static void rxfilter_notify(NetClientState *nc)
}
}
-static char *mac_strdup_printf(const uint8_t *mac)
-{
- return g_strdup_printf("%.2x:%.2x:%.2x:%.2x:%.2x:%.2x", mac[0],
- mac[1], mac[2], mac[3], mac[4], mac[5]);
-}
-
static intList *get_vlan_table(VirtIONet *n)
{
intList *list, *entry;
@@ -284,12 +278,12 @@ static RxFilterInfo *virtio_net_query_rxfilter(NetClientState *nc)
info->multicast_overflow = n->mac_table.multi_overflow;
info->unicast_overflow = n->mac_table.uni_overflow;
- info->main_mac = mac_strdup_printf(n->mac);
+ info->main_mac = qemu_mac_strdup_printf(n->mac);
str_list = NULL;
for (i = 0; i < n->mac_table.first_multi; i++) {
entry = g_malloc0(sizeof(*entry));
- entry->value = mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN);
+ entry->value = qemu_mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN);
entry->next = str_list;
str_list = entry;
}
@@ -298,7 +292,7 @@ static RxFilterInfo *virtio_net_query_rxfilter(NetClientState *nc)
str_list = NULL;
for (i = n->mac_table.first_multi; i < n->mac_table.in_use; i++) {
entry = g_malloc0(sizeof(*entry));
- entry->value = mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN);
+ entry->value = qemu_mac_strdup_printf(n->mac_table.macs + i * ETH_ALEN);
entry->next = str_list;
str_list = entry;
}
--
1.7.10.4
next prev parent reply other threads:[~2015-01-16 8:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 8:51 [Qemu-devel] [PATCH v4 00/10] rocker: add new rocker ethernet switch device sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 01/10] net: add MAC address string printer sfeldma
2015-01-16 8:51 ` sfeldma [this message]
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 03/10] rocker: add register programming guide sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 04/10] pci: add rocker device ID sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 05/10] pci: add network device class 'other' for network switches sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 06/10] rocker: add new rocker switch device sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 07/10] qmp: add rocker device support sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 08/10] rocker: add tests sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 09/10] MAINTAINERS: add rocker sfeldma
2015-01-16 8:51 ` [Qemu-devel] [PATCH v4 10/10] rocker: timestamp on the debug logs helps correlate with events in the VM sfeldma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421398294-22035-3-git-send-email-sfeldma@gmail.com \
--to=sfeldma@gmail.com \
--cc=dsahern@gmail.com \
--cc=eblake@redhat.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=roopa@cumulusnetworks.com \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).