From: Gerd Hoffmann <kraxel@redhat.com>
To: Don Koch <dkoch@verizon.com>
Cc: qemu-devel@nongnu.org, Anthony Liguori <aliguori@amazon.com>
Subject: Re: [Qemu-devel] [PATCH] Add trace messages to input.c.
Date: Mon, 19 Jan 2015 08:34:22 +0100 [thread overview]
Message-ID: <1421652862.18666.5.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1421435282-1598-1-git-send-email-dkoch@verizon.com>
On Fr, 2015-01-16 at 14:08 -0500, Don Koch wrote:
> Signed-off-by: Don Koch <dkoch@verizon.com>
> + trace_do_mouse_set(mon, index);
First, I think we should have a better name for that one, maybe
"input_mouse_set" ?
Second I'm wondering what the use case is. The place is a bit strange
(tracing management not guest behavior), also all the existing input
trace points log the device index so you can already see how the events
are routed ...
cheers,
Gerd
next prev parent reply other threads:[~2015-01-19 7:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 19:08 [Qemu-devel] [PATCH] Add trace messages to input.c Don Koch
2015-01-19 7:34 ` Gerd Hoffmann [this message]
2015-01-19 14:31 ` Don Koch
2015-01-22 10:01 ` Gerd Hoffmann
2015-01-22 14:32 ` Don Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421652862.18666.5.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=aliguori@amazon.com \
--cc=dkoch@verizon.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).