From: John Snow <jsnow@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, marc.mari.barcelo@gmail.com, armbru@redhat.com,
mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com,
jsnow@redhat.com
Subject: [Qemu-devel] [PATCH v2 10/15] qtest/ahci: remove pcibus global
Date: Mon, 19 Jan 2015 15:15:58 -0500 [thread overview]
Message-ID: <1421698563-6977-11-git-send-email-jsnow@redhat.com> (raw)
In-Reply-To: <1421698563-6977-1-git-send-email-jsnow@redhat.com>
Rely on the PCI Device's bus pointer instead.
One less global to worry about.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
---
tests/ahci-test.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/tests/ahci-test.c b/tests/ahci-test.c
index 96fb45c..0cc56ab 100644
--- a/tests/ahci-test.c
+++ b/tests/ahci-test.c
@@ -45,7 +45,6 @@
/*** Globals ***/
static QGuestAllocator *guest_malloc;
-static QPCIBus *pcibus;
static char tmp_path[] = "/tmp/qtest.XXXXXX";
static bool ahci_pedantic;
@@ -100,6 +99,7 @@ static QPCIDevice *get_ahci_device(uint32_t *fingerprint)
{
QPCIDevice *ahci;
uint32_t ahci_fingerprint;
+ QPCIBus *pcibus;
pcibus = qpci_init_pc();
@@ -123,15 +123,13 @@ static QPCIDevice *get_ahci_device(uint32_t *fingerprint)
return ahci;
}
-static void free_ahci_device(QPCIDevice *ahci)
+static void free_ahci_device(QPCIDevice *dev)
{
+ QPCIBus *pcibus = dev ? dev->bus : NULL;
+
/* libqos doesn't have a function for this, so free it manually */
- g_free(ahci);
-
- if (pcibus) {
- qpci_free_pc(pcibus);
- pcibus = NULL;
- }
+ g_free(dev);
+ qpci_free_pc(pcibus);
}
/*** Test Setup & Teardown ***/
--
1.9.3
next prev parent reply other threads:[~2015-01-19 20:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 20:15 [Qemu-devel] [PATCH v2 00/15] ahci-test preliminary refactoring John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 01/15] libqos: Split apart pc_alloc_init John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 02/15] qtest/ahci: Create ahci.h John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 03/15] libqos: create libqos.c John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 04/15] libqos: add qtest_vboot John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 05/15] libqos: add alloc_init_flags John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 06/15] libqos: Update QGuestAllocator to be opaque John Snow
2015-01-27 21:22 ` Marc Marí
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 07/15] libqos: add pc specific interface John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 08/15] qtest/ahci: Store hba_base in AHCIQState John Snow
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 09/15] qtest/ahci: finalize AHCIQState consolidation John Snow
2015-01-19 20:15 ` John Snow [this message]
2015-01-19 20:15 ` [Qemu-devel] [PATCH v2 11/15] qtest/ahci: remove guest_malloc global John Snow
2015-01-19 20:16 ` [Qemu-devel] [PATCH v2 12/15] libqos/ahci: Functional register helpers John Snow
2015-01-28 10:26 ` Paolo Bonzini
2015-01-19 20:16 ` [Qemu-devel] [PATCH v2 13/15] qtest/ahci: remove getter/setter macros John Snow
2015-01-19 20:16 ` [Qemu-devel] [PATCH v2 14/15] qtest/ahci: Bookmark FB and CLB pointers John Snow
2015-01-19 20:16 ` [Qemu-devel] [PATCH v2 15/15] libqos/ahci: create libqos/ahci.c John Snow
2015-01-28 10:26 ` Paolo Bonzini
2015-01-27 21:05 ` [Qemu-devel] [PATCH v2 00/15] ahci-test preliminary refactoring John Snow
2015-02-12 15:51 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421698563-6977-11-git-send-email-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=marc.mari.barcelo@gmail.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).