From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDJvB-0002la-PS for qemu-devel@nongnu.org; Mon, 19 Jan 2015 16:31:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDJv9-0007mm-A7 for qemu-devel@nongnu.org; Mon, 19 Jan 2015 16:31:41 -0500 Received: from smtp2-g21.free.fr ([212.27.42.2]:58435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDJv9-0007mh-3i for qemu-devel@nongnu.org; Mon, 19 Jan 2015 16:31:39 -0500 From: =?UTF-8?q?Herv=C3=A9=20Poussineau?= Date: Mon, 19 Jan 2015 22:28:33 +0100 Message-Id: <1421702918-27143-4-git-send-email-hpoussin@reactos.org> In-Reply-To: <1421702918-27143-1-git-send-email-hpoussin@reactos.org> References: <1421702918-27143-1-git-send-email-hpoussin@reactos.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 3/7] jazz: remove usage of isa_mem_base List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Leon Alrae , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aurelien Jarno Do assorted changes in memory-mapped rtc interface. Also fix size of ISA I/O memory region, which should be 0x10000 bytes. Signed-off-by: Herv=C3=A9 Poussineau --- hw/mips/mips_jazz.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/hw/mips/mips_jazz.c b/hw/mips/mips_jazz.c index 738e9c7..ef5dd7d 100644 --- a/hw/mips/mips_jazz.c +++ b/hw/mips/mips_jazz.c @@ -60,13 +60,16 @@ static void main_cpu_reset(void *opaque) =20 static uint64_t rtc_read(void *opaque, hwaddr addr, unsigned size) { - return cpu_inw(0x71); + uint8_t val; + address_space_read(&address_space_memory, 0x90000071, &val, 1); + return val; } =20 static void rtc_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) { - cpu_outw(0x71, val & 0xff); + uint8_t buf =3D val & 0xff; + address_space_write(&address_space_memory, 0x90000071, &buf, 1); } =20 static const MemoryRegionOps rtc_ops =3D { @@ -124,7 +127,6 @@ static void mips_jazz_init(MachineState *machine, enum jazz_model_e jazz_model) { MemoryRegion *address_space =3D get_system_memory(); - MemoryRegion *address_space_io =3D get_system_io(); const char *cpu_model =3D machine->cpu_model; char *filename; int bios_size, n; @@ -134,7 +136,8 @@ static void mips_jazz_init(MachineState *machine, qemu_irq *rc4030, *i8259; rc4030_dma *dmas; void* rc4030_opaque; - MemoryRegion *isa =3D g_new(MemoryRegion, 1); + MemoryRegion *isa_mem =3D g_new(MemoryRegion, 1); + MemoryRegion *isa_io =3D g_new(MemoryRegion, 1); MemoryRegion *rtc =3D g_new(MemoryRegion, 1); MemoryRegion *i8042 =3D g_new(MemoryRegion, 1); MemoryRegion *dma_dummy =3D g_new(MemoryRegion, 1); @@ -219,8 +222,14 @@ static void mips_jazz_init(MachineState *machine, memory_region_init_io(dma_dummy, NULL, &dma_dummy_ops, NULL, "dummy_= dma", 0x1000); memory_region_add_subregion(address_space, 0x8000d000, dma_dummy); =20 + /* ISA bus: IO space at 0x90000000, mem space at 0x91000000 */ + memory_region_init(isa_io, NULL, "isa-io", 0x00010000); + memory_region_init(isa_mem, NULL, "isa-mem", 0x01000000); + memory_region_add_subregion(address_space, 0x90000000, isa_io); + memory_region_add_subregion(address_space, 0x91000000, isa_mem); + isa_bus =3D isa_bus_new(NULL, isa_mem, isa_io); + /* ISA devices */ - isa_bus =3D isa_bus_new(NULL, get_system_memory(), address_space_io)= ; i8259 =3D i8259_init(isa_bus, env->irq[4]); isa_bus_irqs(isa_bus, i8259); cpu_exit_irq =3D qemu_allocate_irqs(cpu_request_exit, NULL, 1); @@ -228,12 +237,6 @@ static void mips_jazz_init(MachineState *machine, pit =3D pit_init(isa_bus, 0x40, 0, NULL); pcspk_init(isa_bus, pit); =20 - /* ISA IO space at 0x90000000 */ - memory_region_init_alias(isa, NULL, "isa_mmio", - get_system_io(), 0, 0x01000000); - memory_region_add_subregion(address_space, 0x90000000, isa); - isa_mem_base =3D 0x11000000; - /* Video card */ switch (jazz_model) { case JAZZ_MAGNUM: --=20 1.7.10.4