From: Greg Bellows <greg.bellows@linaro.org>
To: qemu-devel@nongnu.org, peter.maydell@linaro.org,
christoffer.dall@linaro.org
Cc: Greg Bellows <greg.bellows@linaro.org>
Subject: [Qemu-devel] [PATCH 5/5] target-arm: Adjust kernel load address for Image
Date: Mon, 19 Jan 2015 16:30:21 -0600 [thread overview]
Message-ID: <1421706621-23731-6-git-send-email-greg.bellows@linaro.org> (raw)
In-Reply-To: <1421706621-23731-1-git-send-email-greg.bellows@linaro.org>
Adjust the kernel load offset by 0x8000 if not a zImage.
Signed-off-by: Pranavkumar Sawargaonkar <address@hidden>
Signed-off-by: Greg Bellows <greg.bellows@linaro.org>
---
hw/arm/boot.c | 33 ++++++++++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 52ebd8b..b581cea 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -537,6 +537,32 @@ static void load_image_to_fw_cfg(FWCfgState *fw_cfg, uint16_t size_key,
fw_cfg_add_bytes(fw_cfg, data_key, data, size);
}
+static int check_load_zimage(const char *filename)
+{
+ int fd;
+ uint8_t buf[40];
+ uint32_t *p = (uint32_t *) &buf[36];
+
+ fd = open(filename, O_RDONLY | O_BINARY);
+ if (fd < 0) {
+ perror(filename);
+ return -1;
+ }
+
+ memset(buf, 0, sizeof(buf));
+ if (read(fd, buf, sizeof(buf)) != sizeof(buf)) {
+ close(fd);
+ return -1;
+ }
+
+ /* Check for zImage magic number */
+ if (*p == 0x016F2818) {
+ return 1;
+ }
+
+ return 0;
+}
+
void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info)
{
CPUState *cs;
@@ -613,7 +639,12 @@ void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info)
primary_loader = bootloader;
kernel_load_offset = KERNEL_LOAD_ADDR;
elf_machine = EM_ARM;
- }
+
+ if (!check_load_zimage(info->kernel_filename)) {
+ /* Assuming we are loading Image hence aligning it to 0x8000 */
+ kernel_load_offset -= 0x8000;
+ }
+ }
info->dtb_filename = qemu_opt_get(qemu_get_machine_opts(), "dtb");
--
1.8.3.2
next prev parent reply other threads:[~2015-01-19 22:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 22:30 [Qemu-devel] [PATCH 0/5] target-arm: ARM64: Adding EL1 AARCH32 guest support Greg Bellows
2015-01-19 22:30 ` [Qemu-devel] [PATCH 1/5] target-arm: Add ARM CPU feature parsing Greg Bellows
2015-01-20 14:19 ` Alex Bennée
2015-01-20 14:49 ` Greg Bellows
2015-01-21 10:57 ` Alex Bennée
2015-01-20 15:22 ` Igor Mammedov
2015-01-20 15:34 ` Peter Maydell
2015-01-20 15:59 ` Igor Mammedov
2015-01-20 16:08 ` Peter Maydell
2015-01-20 16:25 ` Igor Mammedov
2015-01-20 22:45 ` Greg Bellows
2015-01-21 11:33 ` Igor Mammedov
2015-01-20 15:34 ` Greg Bellows
2015-01-20 16:02 ` Eduardo Habkost
2015-01-20 16:05 ` Igor Mammedov
2015-01-19 22:30 ` [Qemu-devel] [PATCH 2/5] target-arm: Add feature parsing to virt Greg Bellows
2015-01-20 16:58 ` Alex Bennée
2015-01-19 22:30 ` [Qemu-devel] [PATCH 3/5] target-arm: Add 32/64-bit register sync Greg Bellows
2015-01-19 22:30 ` [Qemu-devel] [PATCH 4/5] target-arm: Add AArch32 guest support to KVM64 Greg Bellows
2015-01-20 16:57 ` Alex Bennée
2015-01-20 20:03 ` Greg Bellows
2015-01-21 10:54 ` Alex Bennée
2015-01-21 10:56 ` Peter Maydell
2015-01-19 22:30 ` Greg Bellows [this message]
2015-01-20 10:21 ` [Qemu-devel] [PATCH 0/5] target-arm: ARM64: Adding EL1 AARCH32 guest support Sergey Fedorov
2015-01-20 10:26 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421706621-23731-6-git-send-email-greg.bellows@linaro.org \
--to=greg.bellows@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).