From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDVYF-0001Js-7z for qemu-devel@nongnu.org; Tue, 20 Jan 2015 04:56:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDVYB-0005We-US for qemu-devel@nongnu.org; Tue, 20 Jan 2015 04:56:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:55768) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDVYB-0005WM-OO for qemu-devel@nongnu.org; Tue, 20 Jan 2015 04:56:43 -0500 From: Markus Armbruster Date: Tue, 20 Jan 2015 10:56:37 +0100 Message-Id: <1421747797-2762-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] s390: Plug memory leak on s390_pci_generate_event() error path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: cornelia.huck@de.ibm.com, frank.blaschka@de.ibm.com Signed-off-by: Markus Armbruster --- hw/s390x/s390-pci-bus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c index 1201b8d..d25ac74 100644 --- a/hw/s390x/s390-pci-bus.c +++ b/hw/s390x/s390-pci-bus.c @@ -187,7 +187,7 @@ S390PCIBusDevice *s390_pci_find_dev_by_fh(uint32_t fh) static void s390_pci_generate_event(uint8_t cc, uint16_t pec, uint32_t fh, uint32_t fid, uint64_t faddr, uint32_t e) { - SeiContainer *sei_cont = g_malloc0(sizeof(SeiContainer)); + SeiContainer *sei_cont; S390pciState *s = S390_PCI_HOST_BRIDGE( object_resolve_path(TYPE_S390_PCI_HOST_BRIDGE, NULL)); @@ -195,6 +195,7 @@ static void s390_pci_generate_event(uint8_t cc, uint16_t pec, uint32_t fh, return; } + sei_cont = g_malloc0(sizeof(SeiContainer)); sei_cont->fh = fh; sei_cont->fid = fid; sei_cont->cc = cc; -- 1.9.3