qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeremy White <jwhite@codeweavers.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v2 4/4] Remove the (broken) passthru option.
Date: Tue, 20 Jan 2015 09:38:31 -0600	[thread overview]
Message-ID: <1421768311-9864-5-git-send-email-jwhite@codeweavers.com> (raw)
In-Reply-To: <1421768311-9864-1-git-send-email-jwhite@codeweavers.com>

That option can be achieved using -e "use_hw=yes hw_type=passthru"

Signed-off-by: Jeremy White <jwhite@codeweavers.com>
---
 libcacard/vscclient.c |   16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

diff --git a/libcacard/vscclient.c b/libcacard/vscclient.c
index fa6041d..8573f50 100644
--- a/libcacard/vscclient.c
+++ b/libcacard/vscclient.c
@@ -41,14 +41,8 @@ print_byte_array(
 
 static void
 print_usage(void) {
-    printf("vscclient [-c <certname> .. -e <emul_args> -d <level>%s] "
-            "<host> <port>\n",
-#ifdef USE_PASSTHRU
-    " -p");
-    printf(" -p use passthrough mode\n");
-#else
-   "");
-#endif
+    printf("vscclient [-c <certname> .. -e <emul_args> -d <level>] "
+            "<host> <port>\n");
     vcard_emul_usage();
 }
 
@@ -673,7 +667,7 @@ main(
     }
 #endif
 
-    while ((c = getopt(argc, argv, "c:e:pd:")) != -1) {
+    while ((c = getopt(argc, argv, "c:e:d:")) != -1) {
         switch (c) {
         case 'c':
             if (cert_count >= MAX_CERTS) {
@@ -685,10 +679,6 @@ main(
         case 'e':
             emul_args = optarg;
             break;
-        case 'p':
-            print_usage();
-            exit(4);
-            break;
         case 'd':
             verbose = get_id_from_string(optarg, 1);
             break;
-- 
1.7.10.4

  parent reply	other threads:[~2015-01-20 15:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 15:38 [Qemu-devel] [PATCH v2 0/4] Add support for passthru cards to libcacard Jeremy White
2015-01-20 15:38 ` [Qemu-devel] [PATCH v2 1/4] Add a configure check for libpcsclite, and an option to enable or disable it Jeremy White
2015-01-20 15:38 ` [Qemu-devel] [PATCH v2 2/4] Add a VCARD_DIRECT implemention to the libcacard smartcard support Jeremy White
2015-01-20 15:38 ` [Qemu-devel] [PATCH v2 3/4] Enable support for passthru (e.g. direct to pcsc) smart cards in the emul_options entry point in libcacard Jeremy White
2015-01-20 15:38 ` Jeremy White [this message]
2015-02-11 15:22 ` [Qemu-devel] [PATCH v2 0/4] Add support for passthru cards to libcacard Jeremy White

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421768311-9864-5-git-send-email-jwhite@codeweavers.com \
    --to=jwhite@codeweavers.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).