From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 06/18] linux-user/elfload.c: Don't use _raw accessor functions
Date: Tue, 20 Jan 2015 15:45:35 +0000 [thread overview]
Message-ID: <1421768747-17240-7-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1421768747-17240-1-git-send-email-peter.maydell@linaro.org>
The _raw accessor functions are an implementation detail that has
leaked out to some callsites. Use get_user_u64() instead of ldq_raw().
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <rth@twiddle.net>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Message-id: 1421334118-3287-5-git-send-email-peter.maydell@linaro.org
---
linux-user/elfload.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index e2596a4..399c021 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -829,8 +829,11 @@ static inline void init_thread(struct target_pt_regs *_regs, struct image_info *
_regs->gpr[1] = infop->start_stack;
#if defined(TARGET_PPC64) && !defined(TARGET_ABI32)
if (get_ppc64_abi(infop) < 2) {
- _regs->gpr[2] = ldq_raw(infop->entry + 8) + infop->load_bias;
- infop->entry = ldq_raw(infop->entry) + infop->load_bias;
+ uint64_t val;
+ get_user_u64(val, infop->entry + 8);
+ _regs->gpr[2] = val + infop->load_bias;
+ get_user_u64(val, infop->entry);
+ infop->entry = val + infop->load_bias;
} else {
_regs->gpr[12] = infop->entry; /* r12 set to global entry address */
}
--
1.9.1
next prev parent reply other threads:[~2015-01-20 15:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 15:45 [Qemu-devel] [PULL 00/18] misc cross-tree patches queue Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 01/18] scripts/qapi-types.py: Add dummy member to empty structs Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 02/18] exec.c: Drop TARGET_HAS_ICE define and checks Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 03/18] cpu_ldst.h: Remove unused ldul_ macros Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 04/18] monitor.c: Use ld*_p() instead of ld*_raw() Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 05/18] target-sparc: Don't use {ld, st}*_raw functions Peter Maydell
2015-01-20 15:45 ` Peter Maydell [this message]
2015-01-20 15:45 ` [Qemu-devel] [PULL 07/18] bsd-user/elfload.c: Don't use ldl() or ldq_raw() Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 08/18] linux-user/vm86.c: Use cpu_ldl_data &c rather than plain ldl &c Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 09/18] linux-user/main.c (m68k): Use get_user_u16 rather than lduw in cpu_loop Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 10/18] target-mips: Don't use _raw load/store accessors Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 11/18] cpu_ldst.h: Drop unused ld/st*_kernel defines Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 12/18] cpu_ldst.h: Remove unused very short ld*/st* defines Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 13/18] cpu_ldst.h: Use inline functions for usermode cpu_ld/st accessors Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 14/18] cpu_ldst_template.h: Use ld*_p directly rather than via ld*_raw macros Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 15/18] cpu_ldst.h: Drop unused _raw macros, saddr() and laddr() Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 16/18] cpu_ldst_template.h: Drop unused cpu_ldfq/stfq/ldfl/stfl accessors Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 17/18] cpu_ldst.h, cpu-all.h, bswap.h: Update documentation on ld/st accessors Peter Maydell
2015-01-20 15:45 ` [Qemu-devel] [PULL 18/18] cpu_ldst.h: Don't define helpers if MMU_MODE*_SUFFIX not defined Peter Maydell
2015-01-20 17:51 ` [Qemu-devel] [PULL 00/18] misc cross-tree patches queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421768747-17240-7-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).