From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40173) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDb0B-0004jB-IN for qemu-devel@nongnu.org; Tue, 20 Jan 2015 10:46:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDb0A-0007VW-Pf for qemu-devel@nongnu.org; Tue, 20 Jan 2015 10:45:59 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:54959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDb0A-0007MQ-Ia for qemu-devel@nongnu.org; Tue, 20 Jan 2015 10:45:58 -0500 Received: from pm215 by mnementh.archaic.org.uk with local (Exim 4.80) (envelope-from ) id 1YDazz-0004V0-LG for qemu-devel@nongnu.org; Tue, 20 Jan 2015 15:45:47 +0000 From: Peter Maydell Date: Tue, 20 Jan 2015 15:45:35 +0000 Message-Id: <1421768747-17240-7-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1421768747-17240-1-git-send-email-peter.maydell@linaro.org> References: <1421768747-17240-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 06/18] linux-user/elfload.c: Don't use _raw accessor functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The _raw accessor functions are an implementation detail that has leaked out to some callsites. Use get_user_u64() instead of ldq_raw(). Signed-off-by: Peter Maydell Reviewed-by: Richard Henderson Reviewed-by: Paolo Bonzini Reviewed-by: Alex Bennée Message-id: 1421334118-3287-5-git-send-email-peter.maydell@linaro.org --- linux-user/elfload.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index e2596a4..399c021 100644 --- a/linux-user/elfload.c +++ b/linux-user/elfload.c @@ -829,8 +829,11 @@ static inline void init_thread(struct target_pt_regs *_regs, struct image_info * _regs->gpr[1] = infop->start_stack; #if defined(TARGET_PPC64) && !defined(TARGET_ABI32) if (get_ppc64_abi(infop) < 2) { - _regs->gpr[2] = ldq_raw(infop->entry + 8) + infop->load_bias; - infop->entry = ldq_raw(infop->entry) + infop->load_bias; + uint64_t val; + get_user_u64(val, infop->entry + 8); + _regs->gpr[2] = val + infop->load_bias; + get_user_u64(val, infop->entry); + infop->entry = val + infop->load_bias; } else { _regs->gpr[12] = infop->entry; /* r12 set to global entry address */ } -- 1.9.1