From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: marcel.a@redhat.com, claudio.fontana@huawei.com, mst@redhat.com
Subject: [Qemu-devel] [PATCH v4 2/7] pc: acpi-build: cleanup AcpiPmInfo initialization
Date: Tue, 20 Jan 2015 15:52:27 +0000 [thread overview]
Message-ID: <1421769152-23285-3-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1421769152-23285-1-git-send-email-imammedo@redhat.com>
zero initialize AcpiPmInfo struct to reduce code bloat
a little bit.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Claudio Fontana <claudio.fontana@huawei.com>
---
hw/i386/acpi-build.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 6a2e9c5..e0b66e7 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -172,6 +172,8 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
Object *obj = NULL;
QObject *o;
+ memset(pm, 0, sizeof(*pm));
+
if (piix) {
obj = piix;
}
@@ -184,22 +186,16 @@ static void acpi_get_pm_info(AcpiPmInfo *pm)
o = object_property_get_qobject(obj, ACPI_PM_PROP_S3_DISABLED, NULL);
if (o) {
pm->s3_disabled = qint_get_int(qobject_to_qint(o));
- } else {
- pm->s3_disabled = false;
}
qobject_decref(o);
o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_DISABLED, NULL);
if (o) {
pm->s4_disabled = qint_get_int(qobject_to_qint(o));
- } else {
- pm->s4_disabled = false;
}
qobject_decref(o);
o = object_property_get_qobject(obj, ACPI_PM_PROP_S4_VAL, NULL);
if (o) {
pm->s4_val = qint_get_int(qobject_to_qint(o));
- } else {
- pm->s4_val = false;
}
qobject_decref(o);
--
1.8.3.1
next prev parent reply other threads:[~2015-01-20 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 15:52 [Qemu-devel] [PATCH v4 0/7] pc: acpi: various fixes and cleanups Igor Mammedov
2015-01-20 15:52 ` [Qemu-devel] [PATCH v4 1/7] pc: acpi: fix WindowsXP BSOD when memory hotplug is enabled Igor Mammedov
2015-01-20 15:52 ` Igor Mammedov [this message]
2015-01-20 15:52 ` [Qemu-devel] [PATCH v4 3/7] acpi: build_append_nameseg(): add padding if necessary Igor Mammedov
2015-01-20 15:52 ` [Qemu-devel] [PATCH v4 4/7] acpi: move generic aml building helpers into dedictated file Igor Mammedov
2015-01-20 15:52 ` [Qemu-devel] [PATCH v4 5/7] acpi: add build_append_namestring() helper Igor Mammedov
2015-01-20 15:52 ` [Qemu-devel] [PATCH v4 6/7] acpi: drop min-bytes in build_package() Igor Mammedov
2015-01-20 15:52 ` [Qemu-devel] [PATCH v4 7/7] pc: acpi-build: simplify PCI bus tree generation Igor Mammedov
2015-01-20 16:29 ` [Qemu-devel] [PATCH v4 0/7] pc: acpi: various fixes and cleanups Michael S. Tsirkin
2015-01-20 17:24 ` Igor Mammedov
2015-01-20 20:38 ` Igor Mammedov
2015-01-20 22:02 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421769152-23285-3-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=claudio.fontana@huawei.com \
--cc=marcel.a@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).