From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDbTw-0006SJ-4Y for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:16:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YDbTv-0008Bb-C3 for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:16:44 -0500 Received: from mnementh.archaic.org.uk ([2001:8b0:1d0::1]:54960) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YDbTv-0008BV-4m for qemu-devel@nongnu.org; Tue, 20 Jan 2015 11:16:43 -0500 From: Peter Maydell Date: Tue, 20 Jan 2015 16:16:40 +0000 Message-Id: <1421770600-17525-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] qemu-timer.c: Trim list of included headers List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Paolo Bonzini , patches@linaro.org qemu-timer.c was including a lot more headers than it needed to, presumably for historical reasons. In particular, it included ui/console.h; this now tries to pull in , which will cause a compilation failure in --disable-tools --disable-system configurations when running "make check" (which builds qemu-timer.c, even though the linux-user binaries themselves don't need it). Fix this build failure by trimming down the set of included headers severely -- we only really need main-loop.h and timer.h. Signed-off-by: Peter Maydell --- I'm not sure exactly when this broke -- it's not a config I run as part of pullreq processing. qemu-timer.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/qemu-timer.c b/qemu-timer.c index 98d9d1b..a77fb47 100644 --- a/qemu-timer.c +++ b/qemu-timer.c @@ -22,13 +22,9 @@ * THE SOFTWARE. */ -#include "sysemu/sysemu.h" -#include "monitor/monitor.h" -#include "ui/console.h" - -#include "hw/hw.h" - +#include "qemu/main-loop.h" #include "qemu/timer.h" + #ifdef CONFIG_POSIX #include #endif -- 1.9.1