From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: edgar.iglesias@gmail.com, peter.crosthwaite@xilinx.com
Subject: [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad
Date: Wed, 21 Jan 2015 14:18:37 +0100 [thread overview]
Message-ID: <1421846317-7088-1-git-send-email-armbru@redhat.com> (raw)
The "fall through" added by the commit is clearly intentional. Mark
it so. Hushes up Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/net/xilinx_ethlite.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
index 9536f64..ad6b553 100644
--- a/hw/net/xilinx_ethlite.c
+++ b/hw/net/xilinx_ethlite.c
@@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr,
if (!(value & CTRL_S)) {
qemu_flush_queued_packets(qemu_get_queue(s->nic));
}
+ /* fall through */
case R_TX_LEN0:
case R_TX_LEN1:
case R_TX_GIE0:
--
1.9.3
next reply other threads:[~2015-01-21 13:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 13:18 Markus Armbruster [this message]
2015-02-04 9:45 ` [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad Markus Armbruster
2015-02-04 16:47 ` Peter Crosthwaite
2015-02-10 12:03 ` Markus Armbruster
2015-02-10 18:59 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421846317-7088-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).