* [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad
@ 2015-01-21 13:18 Markus Armbruster
2015-02-04 9:45 ` Markus Armbruster
2015-02-04 16:47 ` Peter Crosthwaite
0 siblings, 2 replies; 5+ messages in thread
From: Markus Armbruster @ 2015-01-21 13:18 UTC (permalink / raw)
To: qemu-devel; +Cc: edgar.iglesias, peter.crosthwaite
The "fall through" added by the commit is clearly intentional. Mark
it so. Hushes up Coverity.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/net/xilinx_ethlite.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
index 9536f64..ad6b553 100644
--- a/hw/net/xilinx_ethlite.c
+++ b/hw/net/xilinx_ethlite.c
@@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr,
if (!(value & CTRL_S)) {
qemu_flush_queued_packets(qemu_get_queue(s->nic));
}
+ /* fall through */
case R_TX_LEN0:
case R_TX_LEN1:
case R_TX_GIE0:
--
1.9.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad
2015-01-21 13:18 [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad Markus Armbruster
@ 2015-02-04 9:45 ` Markus Armbruster
2015-02-04 16:47 ` Peter Crosthwaite
1 sibling, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2015-02-04 9:45 UTC (permalink / raw)
To: qemu-devel; +Cc: edgar.iglesias, peter.crosthwaite
Ping?
Markus Armbruster <armbru@redhat.com> writes:
> The "fall through" added by the commit is clearly intentional. Mark
> it so. Hushes up Coverity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> hw/net/xilinx_ethlite.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
> index 9536f64..ad6b553 100644
> --- a/hw/net/xilinx_ethlite.c
> +++ b/hw/net/xilinx_ethlite.c
> @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr,
> if (!(value & CTRL_S)) {
> qemu_flush_queued_packets(qemu_get_queue(s->nic));
> }
> + /* fall through */
> case R_TX_LEN0:
> case R_TX_LEN1:
> case R_TX_GIE0:
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad
2015-01-21 13:18 [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad Markus Armbruster
2015-02-04 9:45 ` Markus Armbruster
@ 2015-02-04 16:47 ` Peter Crosthwaite
2015-02-10 12:03 ` Markus Armbruster
1 sibling, 1 reply; 5+ messages in thread
From: Peter Crosthwaite @ 2015-02-04 16:47 UTC (permalink / raw)
To: Markus Armbruster; +Cc: Edgar E. Iglesias, qemu-devel@nongnu.org Developers
On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <armbru@redhat.com> wrote:
> The "fall through" added by the commit is clearly intentional. Mark
> it so. Hushes up Coverity.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> hw/net/xilinx_ethlite.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
> index 9536f64..ad6b553 100644
> --- a/hw/net/xilinx_ethlite.c
> +++ b/hw/net/xilinx_ethlite.c
> @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr,
> if (!(value & CTRL_S)) {
> qemu_flush_queued_packets(qemu_get_queue(s->nic));
> }
> + /* fall through */
> case R_TX_LEN0:
> case R_TX_LEN1:
> case R_TX_GIE0:
> --
> 1.9.3
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad
2015-02-04 16:47 ` Peter Crosthwaite
@ 2015-02-10 12:03 ` Markus Armbruster
2015-02-10 18:59 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 5+ messages in thread
From: Markus Armbruster @ 2015-02-10 12:03 UTC (permalink / raw)
To: qemu-trivial
Cc: Edgar E. Iglesias, Peter Crosthwaite,
qemu-devel@nongnu.org Developers
Since maintainers haven't picked it up: could this go in via -trivial?
Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:
> On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <armbru@redhat.com> wrote:
>> The "fall through" added by the commit is clearly intentional. Mark
>> it so. Hushes up Coverity.
>>
>> Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
> Reviewed-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
>> ---
>> hw/net/xilinx_ethlite.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/hw/net/xilinx_ethlite.c b/hw/net/xilinx_ethlite.c
>> index 9536f64..ad6b553 100644
>> --- a/hw/net/xilinx_ethlite.c
>> +++ b/hw/net/xilinx_ethlite.c
>> @@ -146,6 +146,7 @@ eth_write(void *opaque, hwaddr addr,
>> if (!(value & CTRL_S)) {
>> qemu_flush_queued_packets(qemu_get_queue(s->nic));
>> }
>> + /* fall through */
>> case R_TX_LEN0:
>> case R_TX_LEN1:
>> case R_TX_GIE0:
>> --
>> 1.9.3
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad
2015-02-10 12:03 ` Markus Armbruster
@ 2015-02-10 18:59 ` Michael Tokarev
0 siblings, 0 replies; 5+ messages in thread
From: Michael Tokarev @ 2015-02-10 18:59 UTC (permalink / raw)
To: Markus Armbruster, qemu-trivial
Cc: Edgar E. Iglesias, Peter Crosthwaite,
qemu-devel@nongnu.org Developers
10.02.2015 15:03, Markus Armbruster wrote:
> Since maintainers haven't picked it up: could this go in via -trivial?
>
> Peter Crosthwaite <peter.crosthwaite@xilinx.com> writes:
>
>> On Wed, Jan 21, 2015 at 5:18 AM, Markus Armbruster <armbru@redhat.com> wrote:
>>> The "fall through" added by the commit is clearly intentional. Mark
>>> it so. Hushes up Coverity.
Applied to -trivial, thank you!
/mjt
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-02-10 18:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-21 13:18 [Qemu-devel] [PATCH] xilinx_ethlite: Clean up after commit 2f991ad Markus Armbruster
2015-02-04 9:45 ` Markus Armbruster
2015-02-04 16:47 ` Peter Crosthwaite
2015-02-10 12:03 ` Markus Armbruster
2015-02-10 18:59 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).