From: zhanghailiang <zhang.zhanghailiang@huawei.com>
To: qemu-devel@nongnu.org
Cc: hangaohuai@huawei.com,
zhanghailiang <zhang.zhanghailiang@huawei.com>,
peter.huangpeng@huawei.com, mdroth@linux.vnet.ibm.com,
lcapitulino@redhat.com, lersek@redhat.com
Subject: [Qemu-devel] [PATCH v2 4/5] qga: implement qmp_guest_get_memory_block_size() for Linux with sysfs
Date: Thu, 22 Jan 2015 10:40:05 +0800 [thread overview]
Message-ID: <1421894406-12180-5-git-send-email-zhang.zhanghailiang@huawei.com> (raw)
In-Reply-To: <1421894406-12180-1-git-send-email-zhang.zhanghailiang@huawei.com>
The size of a memory block is architecture dependent, it represents the logical
unit upon which memory online/offline operations are to be performed.
Signed-off-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
---
qga/commands-posix.c | 29 +++++++++++++++++++++++++++--
1 file changed, 27 insertions(+), 2 deletions(-)
diff --git a/qga/commands-posix.c b/qga/commands-posix.c
index 4b41385..44d9e8f 100644
--- a/qga/commands-posix.c
+++ b/qga/commands-posix.c
@@ -2147,8 +2147,33 @@ err:
int64_t qmp_guest_get_memory_block_size(Error **errp)
{
- error_set(errp, QERR_UNSUPPORTED);
- return -1;
+ Error *local_err = NULL;
+ char *dirpath;
+ int dirfd;
+ char *buf;
+ int64_t block_size;
+
+ dirpath = g_strdup_printf("/sys/devices/system/memory/");
+ dirfd = open(dirpath, O_RDONLY | O_DIRECTORY);
+ if (dirfd == -1) {
+ error_setg_errno(errp, errno, "open(\"%s\")", dirpath);
+ g_free(dirpath);
+ return -1;
+ }
+ g_free(dirpath);
+
+ buf = g_malloc0(20);
+ ga_read_sysfs_file(dirfd, "block_size_bytes", buf, 20, &local_err);
+ if (local_err) {
+ g_free(buf);
+ error_propagate(errp, local_err);
+ return -1;
+ }
+
+ block_size = strtol(buf, NULL, 16); /* the unit is bytes */
+ g_free(buf);
+
+ return block_size;
}
#else /* defined(__linux__) */
--
1.7.12.4
next prev parent reply other threads:[~2015-01-22 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 2:40 [Qemu-devel] [PATCH v2 0/5] qga: add three logical memory hotplug related commands zhanghailiang
2015-01-22 2:40 ` [Qemu-devel] [PATCH v2 1/5] qga: introduce three guest memory block commmands with stubs zhanghailiang
2015-02-17 15:24 ` Eric Blake
2015-01-22 2:40 ` [Qemu-devel] [PATCH v2 2/5] qga: implement qmp_guest_get_memory_blocks() for Linux with sysfs zhanghailiang
2015-01-22 2:40 ` [Qemu-devel] [PATCH v2 3/5] qga: implement qmp_guest_set_memory_blocks() " zhanghailiang
2015-01-22 2:40 ` zhanghailiang [this message]
2015-01-22 2:40 ` [Qemu-devel] [PATCH v2 5/5] qga: add memory block command that unsupported to blacklist zhanghailiang
2015-02-12 8:27 ` [Qemu-devel] [PATCH v2 0/5] qga: add three logical memory hotplug related commands zhanghailiang
2015-02-17 2:05 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421894406-12180-5-git-send-email-zhang.zhanghailiang@huawei.com \
--to=zhang.zhanghailiang@huawei.com \
--cc=hangaohuai@huawei.com \
--cc=lcapitulino@redhat.com \
--cc=lersek@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).