Re: [Qemu-devel] [PATCH] hw/input/hid.c Fix capslock hid code

[Gerd Hoffmann <kraxel@redhat.com>]

On Mi, 2015-01-21 at 23:48 +0100, dvaleev@suse.de wrote:
> From: Dinar Valeev <dvaleev@suse.com>
> 
> When ever USB keyboard is used, e.g. '-usbdevice keyboard' pressing
> caps lock key send 0x32 hid code, which is treated as backslash.
> Instead it should be 0x39 code. This affects sending uppercase keys,
> as they typed whith caps lock active.
> 
> While on x86 this can be workarounded by using ps/2 protocol. On
> Power it is crusial as we don't have anything else than USB.
> 
> This is fixes guest automation tasts over vnc.

That probably happens because your test automation vnc client sends
uppercase letters without also sending shift-down/up events.  The qemu
vnc server logic which is supposed to sync up capslock state between
guest and host thinks capslock is pressed on the host then and injects
some synthetic capslock key events.

Just say'ing FYI, that doesn't render the fix invalid, but you may have
wondered why you are not seeing this with a normal vnc client ;)

Added to input queue.

thanks,
  Gerd