From: Gerd Hoffmann <kraxel@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: j_bair@bellsouth.net, qemu-devel@nongnu.org, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] sb16: fix interrupt acknowledgement
Date: Thu, 22 Jan 2015 10:56:49 +0100 [thread overview]
Message-ID: <1421920609.9213.35.camel@nilsson.home.kraxel.org> (raw)
In-Reply-To: <1421771028-5251-1-git-send-email-pbonzini@redhat.com>
On Di, 2015-01-20 at 17:23 +0100, Paolo Bonzini wrote:
> SoundBlaster 16 emulation is very broken and consumes a lot of CPU, but a
> small fix was suggested offlist and it is enough to fix some games. I
> got Epic Pinball to work with the "SoundBlaster Clone" option.
>
> The processing of the interrupt register is wrong due to two missing
> "not"s. This causes the interrupt flag to remain set even after the
> Acknowledge ports have been read (0x0e and 0x0f).
>
> The line was introduced by commit 85571bc (audio merge (malc), 2004-11-07),
> but the code might have been broken before because I did not look closely
> at the huge patches from 10 years ago.
Looks sane, picked up.
thanks,
Gerd
prev parent reply other threads:[~2015-01-22 9:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 16:23 [Qemu-devel] [PATCH] sb16: fix interrupt acknowledgement Paolo Bonzini
2015-01-21 9:32 ` [Qemu-devel] [Qemu-stable] " Michael Tokarev
2015-01-21 10:00 ` Paolo Bonzini
2015-01-22 9:56 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421920609.9213.35.camel@nilsson.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=j_bair@bellsouth.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).