From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YEEVW-0000yO-Pw for qemu-devel@nongnu.org; Thu, 22 Jan 2015 04:56:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YEEVS-00061f-KR for qemu-devel@nongnu.org; Thu, 22 Jan 2015 04:56:58 -0500 Message-ID: <1421920609.9213.35.camel@nilsson.home.kraxel.org> From: Gerd Hoffmann Date: Thu, 22 Jan 2015 10:56:49 +0100 In-Reply-To: <1421771028-5251-1-git-send-email-pbonzini@redhat.com> References: <1421771028-5251-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] sb16: fix interrupt acknowledgement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: j_bair@bellsouth.net, qemu-devel@nongnu.org, qemu-stable@nongnu.org On Di, 2015-01-20 at 17:23 +0100, Paolo Bonzini wrote: > SoundBlaster 16 emulation is very broken and consumes a lot of CPU, but a > small fix was suggested offlist and it is enough to fix some games. I > got Epic Pinball to work with the "SoundBlaster Clone" option. > > The processing of the interrupt register is wrong due to two missing > "not"s. This causes the interrupt flag to remain set even after the > Acknowledge ports have been read (0x0e and 0x0f). > > The line was introduced by commit 85571bc (audio merge (malc), 2004-11-07), > but the code might have been broken before because I did not look closely > at the huge patches from 10 years ago. Looks sane, picked up. thanks, Gerd