qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: qemu-devel@nongnu.org
Cc: seabios@seabios.org, kraxel@redhat.com, mst@redhat.com,
	quintela@redhat.com, agraf@suse.de, alex.williamson@redhat.com,
	kevin@koconnor.net, qemu-ppc@nongnu.org, hare@suse.de,
	imammedo@redhat.com, amit.shah@redhat.com, pbonzini@redhat.com,
	leon.alrae@imgtec.com, aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-devel] [PATCH RFC 04/17] hw/acpi: add _CRS method for extra root busses
Date: Thu, 22 Jan 2015 21:52:30 +0200	[thread overview]
Message-ID: <1421956363-23502-5-git-send-email-marcel@redhat.com> (raw)
In-Reply-To: <1421956363-23502-1-git-send-email-marcel@redhat.com>

Save the IO/mem ranges assigned to the extra root busses
to be removed from the root bus 0 range.

Todo: find the actual bus numbers range for the root busses.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
---
 hw/i386/acpi-build.c | 110 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 110 insertions(+)

diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index cb77fa3..740254a 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -719,6 +719,109 @@ static AcpiAml build_prt(void)
     return method;
  }
 
+typedef struct PciMemoryRangeEntry {
+    QLIST_ENTRY(PciMemoryRangeEntry) entry;
+    PciMemoryRange range;
+} PciMemoryRangeEntry;
+
+typedef QLIST_HEAD(PciMemoryRangeQ, PciMemoryRangeEntry) PciMemoryRangeQ;
+
+static void pci_mem_range_insert(PciMemoryRangeQ *list, PciMemoryRange range) {
+    PciMemoryRangeEntry *entry, *e;
+
+    if (!range.base) {
+        return;
+    }
+
+    if (QLIST_EMPTY(list)) {
+        e = g_malloc(sizeof(*entry));
+        e->range = range;
+        QLIST_INSERT_HEAD(list, e, entry);
+
+        return;
+    }
+
+    QLIST_FOREACH(entry, list, entry) {
+        if (entry->range.limit < range.base) {
+            continue;
+        }
+
+        e = g_malloc(sizeof(*entry));
+        e->range = range;
+        QLIST_INSERT_BEFORE(entry, e, entry);
+        break;
+    }
+}
+
+static void pci_mem_range_list_free(PciMemoryRangeQ *list)
+{
+    PciMemoryRangeEntry *entry, *next;
+
+    QLIST_FOREACH_SAFE(entry, list, entry, next) {
+        QLIST_REMOVE(entry, entry);
+        g_free(entry);
+    }
+}
+
+static AcpiAml build_crs(PcPciInfo *pci, PciInfo *bus_info,
+                         PciMemoryRangeQ *io_ranges,
+                         PciMemoryRangeQ *mem_ranges)
+{
+    PciDeviceInfoList *dev_list;
+    PciMemoryRange range;
+    AcpiAml crs;
+
+    crs = acpi_resource_template();
+    /* todo: find the actual bus number range */
+    aml_append(&crs,
+            acpi_word_bus_number(acpi_min_fixed, acpi_max_fixed, acpi_pos_decode,
+                0x0000, bus_info->bus, bus_info->bus + 1, 0x0000, 0x2));
+
+    for (dev_list = bus_info->devices; dev_list; dev_list = dev_list->next) {
+        PciBridgeInfo *bridge_info = dev_list->value->pci_bridge;
+        if (!dev_list->value->has_pci_bridge) {
+            continue;
+        }
+
+        aml_append(&crs,
+                acpi_word_io(acpi_min_fixed, acpi_max_fixed,
+                    acpi_pos_decode, acpi_entire_range,
+                    0x0000,
+                    bridge_info->bus.io_range->base,
+                    bridge_info->bus.io_range->limit,
+                    0x0000,
+                    bridge_info->bus.io_range->limit -
+                    bridge_info->bus.io_range->base + 1));
+        range = *bridge_info->bus.io_range;
+        pci_mem_range_insert(io_ranges, range);
+
+        aml_append(&crs,
+                acpi_dword_memory(acpi_pos_decode, acpi_min_fixed,
+                    acpi_max_fixed, acpi_non_cacheable, acpi_ReadWrite,
+                    0,
+                    bridge_info->bus.memory_range->base,
+                    bridge_info->bus.memory_range->limit,
+                    0,
+                    bridge_info->bus.memory_range->limit -
+                    bridge_info->bus.memory_range->base + 1));
+        range = *bridge_info->bus.memory_range;
+        pci_mem_range_insert(mem_ranges, range);
+        aml_append(&crs,
+                acpi_dword_memory(acpi_pos_decode, acpi_min_fixed,
+                    acpi_max_fixed, acpi_non_cacheable, acpi_ReadWrite,
+                    0,
+                    bridge_info->bus.prefetchable_range->base,
+                    bridge_info->bus.prefetchable_range->limit,
+                    0,
+                    bridge_info->bus.prefetchable_range->limit -
+                    bridge_info->bus.prefetchable_range->base + 1));
+        range = *bridge_info->bus.prefetchable_range;
+        pci_mem_range_insert(mem_ranges, range);
+    }
+
+    return crs;
+}
+
 static void
 build_ssdt(AcpiAml *table_aml, GArray *linker,
            AcpiCpuInfo *cpu, AcpiPmInfo *pm, AcpiMiscInfo *misc,
@@ -729,6 +832,8 @@ build_ssdt(AcpiAml *table_aml, GArray *linker,
     unsigned acpi_cpus = guest_info->apic_id_limit;
     AcpiAml pkg, scope, dev, method, crs, field, ifctx, ssdt;
     int i;
+    PciMemoryRangeQ io_ranges = QLIST_HEAD_INITIALIZER(io_ranges);
+    PciMemoryRangeQ mem_ranges = QLIST_HEAD_INITIALIZER(mem_ranges);
 
     /* The current AML generator can cover the APIC ID range [0..255],
      * inclusive, for VCPU hotplug. */
@@ -762,9 +867,14 @@ build_ssdt(AcpiAml *table_aml, GArray *linker,
             aml_append(&dev,
                 acpi_name_decl("_BBN", acpi_int((uint8_t)bus_info->bus)));
             aml_append(&dev, build_prt());
+            crs = build_crs(pci, bus_info, &io_ranges, &mem_ranges);
+            aml_append(&dev, acpi_name_decl("_CRS", crs));
             aml_append(&scope, dev);
             aml_append(&ssdt, scope);
         }
+
+        pci_mem_range_list_free(&io_ranges);
+        pci_mem_range_list_free(&mem_ranges);
         qapi_free_PciInfoList(info_list);
     }
 
-- 
2.1.0

  parent reply	other threads:[~2015-01-22 19:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-22 19:52 [Qemu-devel] [PATCH RFC 00/17] implement multiple primary busses for pc machines Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 01/17] acpi: added needed acpi constructs Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 02/17] hw/acpi: add support for multiple root busses Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 03/17] hw/apci: add _PRT method for extra " Marcel Apfelbaum
2015-01-22 19:52 ` Marcel Apfelbaum [this message]
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 05/17] hw/acpi: remove from root bus 0 the crs resources used by other busses Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 06/17] hw/pci: move pci bus related code to separate files Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 07/17] hw/pci: made pci_bus_is_root a PCIBusClass method Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 08/17] hw/pci: made pci_bus_num " Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 09/17] hw/pci: introduce TYPE_PCI_MAIN_HOST_BRIDGE interface Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 10/17] hw/pci: removed 'rootbus nr is 0' assumption from qmp_pci_query Marcel Apfelbaum
2015-01-23  7:57   ` Michael S. Tsirkin
2015-01-23  8:28     ` Marcel Apfelbaum
2015-01-23  9:15       ` Michael S. Tsirkin
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 11/17] hw/pci: implement iteration over multiple host bridges Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 12/17] hw/pci: introduce PCI Expander Bridge (PXB) Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 13/17] hw/pci: inform bios if the system has more than one pci bridge Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 14/17] hw/pci: piix - suport multiple host bridges Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 15/17] hw/pxb: add map_irq func Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 16/17] hw/pci-bridge: hack - disable shpc bar (will be removed from the series) Marcel Apfelbaum
2015-01-22 19:52 ` [Qemu-devel] [PATCH RFC 17/17] hw/acpi: hack - generate dummy region ranges for first acpi-build " Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1421956363-23502-5-git-send-email-marcel@redhat.com \
    --to=marcel@redhat.com \
    --cc=agraf@suse.de \
    --cc=alex.williamson@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=aurelien@aurel32.net \
    --cc=hare@suse.de \
    --cc=imammedo@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=leon.alrae@imgtec.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=quintela@redhat.com \
    --cc=rth@twiddle.net \
    --cc=seabios@seabios.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).