qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Wei Huang <wei@redhat.com>
Subject: [Qemu-devel] [PULL 13/19] kvm_stat: Print errno when syscall to perf_event_open() fails
Date: Mon, 26 Jan 2015 10:24:24 +0100	[thread overview]
Message-ID: <1422264270-19278-14-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1422264270-19278-1-git-send-email-pbonzini@redhat.com>

From: Wei Huang <wei@redhat.com>

kvm_stat uses syscall() to call perf_event_open(). If this function
call fails, the returned value is -1, which doesn't tell the details
of such failure (i.e. ENOSYS or EINVAL). This patch retrieves errno
and prints it when syscall() fails. The error message will look like
"Exception: perf_event_open failed, errno = 38".

Signed-off-by: Wei Huang <wei@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 scripts/kvm/kvm_stat | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index 95c650b..8f6f007 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -13,6 +13,7 @@
 
 import curses
 import sys, os, time, optparse, ctypes
+from ctypes import *
 
 class DebugfsProvider(object):
     def __init__(self):
@@ -247,6 +248,9 @@ import struct, array
 
 libc = ctypes.CDLL('libc.so.6')
 syscall = libc.syscall
+get_errno = libc.__errno_location
+get_errno.restype = POINTER(c_int)
+
 class perf_event_attr(ctypes.Structure):
     _fields_ = [('type', ctypes.c_uint32),
                 ('size', ctypes.c_uint32),
@@ -330,7 +334,8 @@ class Event(object):
             group_leader = group.events[0].fd
         fd = _perf_event_open(attr, -1, group.cpu, group_leader, 0)
         if fd == -1:
-            raise Exception('perf_event_open failed')
+            err = get_errno()[0]
+            raise Exception('perf_event_open failed, errno = ' + err.__str__())
         if filter:
             import fcntl
             fcntl.ioctl(fd, ioctl_numbers['SET_FILTER'], filter)
-- 
1.8.3.1

  parent reply	other threads:[~2015-01-26  9:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  9:24 [Qemu-devel] [PULL 00/19] i386, KVM, misc changes for 2015-01-26 Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 01/19] pc: fix KVM features in pc-1.3 and earlier machine types Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 02/19] tests/multiboot: Update reference output Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 03/19] multiboot: Fix offset of bootloader name Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 04/19] tests/multiboot: Add test for modules Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 05/19] target-i386: use vmstate_offset_sub_array for AVX registers Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 06/19] target-i386: make xmm_regs 512-bit wide Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 07/19] qemu-timer: add timer_init and timer_init_ns/us/ms Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 08/19] qemu-timer: introduce timer_deinit Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 09/19] vmstate: accept QEMUTimer in VMSTATE_TIMER*, add VMSTATE_TIMER_PTR* Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 10/19] hw: misc, add educational driver Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 11/19] kvm_stat: Add aarch64 support Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 12/19] kvm_stat: Update exit reasons to the latest defintion Paolo Bonzini
2015-01-26  9:24 ` Paolo Bonzini [this message]
2015-01-26  9:24 ` [Qemu-devel] [PULL 14/19] apic: do not dereference pointer before it is checked for NULL Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 15/19] .travis.yml: Add "--enable-modules" Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 16/19] exec: fix madvise of NULL pointer Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 17/19] sparse: Fix build with sparse on .S files Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 18/19] target-i386: Disable HLE and RTM on Haswell & Broadwell Paolo Bonzini
2015-01-26  9:24 ` [Qemu-devel] [PULL 19/19] kvm_stat: Add RESET support for perf event ioctl Paolo Bonzini
2015-01-26 10:30 ` [Qemu-devel] [PULL 00/19] i386, KVM, misc changes for 2015-01-26 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1422264270-19278-14-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).