From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YFhb1-0004lE-Ik for qemu-devel@nongnu.org; Mon, 26 Jan 2015 06:12:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YFhb0-0001ep-HB for qemu-devel@nongnu.org; Mon, 26 Jan 2015 06:12:43 -0500 Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 26 Jan 2015 12:12:25 +0100 Message-Id: <1422270747-23994-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1422270747-23994-1-git-send-email-pbonzini@redhat.com> References: <1422270747-23994-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 5/7] cutils: refine strtol error handling in parse_debug_env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, armbru@redhat.com Avoid truncation of a 64-bit long to a 32-bit int, and check for errno (especially ERANGE). Signed-off-by: Paolo Bonzini --- util/cutils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/cutils.c b/util/cutils.c index dbe7412..f227064 100644 --- a/util/cutils.c +++ b/util/cutils.c @@ -523,7 +523,7 @@ int parse_debug_env(const char *name, int max, int initial) { char *debug_env = getenv(name); char *inv = NULL; - int debug; + long debug; if (!debug_env) { return initial; @@ -532,7 +532,7 @@ int parse_debug_env(const char *name, int max, int initial) if (inv == debug_env) { return initial; } - if (debug < 0 || debug > max) { + if (debug < 0 || debug > max || errno != 0) { fprintf(stderr, "warning: %s not in [0, %d]", name, max); return initial; } -- 1.8.3.1